1635117 - Make about:processes localizable

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P5)

Description

[David Teller [:Yoric] - still alive but not very active]

Bug 1632794 brings about partial localization for about:processes, but not for e.g. numbers, percentages, etc. We should work on this.

Comment 1

[Chris Peterson [:cpeterson]]

We should make about:processes localizable before we ship Fission MVP, but it's a low priority for now because it is an internal developer tool.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #1)

We should make about:processes localizable before we ship Fission MVP, but it's a low priority for now because it is an internal developer tool.

Moving to Fission M7 Beta milestone because we want to be feature complete before Fission rides from Nightly to Beta. All features and tests should be Fission compatible (or granted an exception) before Beta. The Fission MVP milestone is for critical bugs we find in Firefox Beta that will block Fission from riding to Release.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - localize process names in about:processes;r?florian

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0c88b367dc
localize process names in about:processes;r=florian,Gijs

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cf0c88b367dc

Comment 7

[Francesco Lodolo [:flod]]

I don't think this bug should be closed, given about:processes is not localizable yet.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

(In reply to Francesco Lodolo [:flod] from comment #7)

I don't think this bug should be closed, given about:processes is not localizable yet.

It's getting there :)

But yeah, we're still missing localization of numbers.

Comment 9

[Neha Kochar [:neha]]

(In reply to Francesco Lodolo [:flod] from comment #7)

I don't think this bug should be closed, given about:processes is not localizable yet.

Could you please specify what work is left?

Comment 10

[Francesco Lodolo [:flod]]

I have no visibility about what features are still missing (e.g. the reference to numbers in comment 8). Looking at the file as a whole, there are a handful of IDs that should be fixed and got missed in review (they're using CamelCase, when they should only be lowercase).

When the content is ready, the FTL file needs to be moved in a localizable path, and all references to it updated. Currently it's in toolkit/components/aboutprocesses/content/, and not exposed for localization. For that to happen, it should move to toolkit/locales/en-US/toolkit/about/.

Comment 11

[David Teller [:Yoric] - still alive but not very active]

(In reply to Francesco Lodolo [:flod] from comment #10)

I have no visibility about what features are still missing (e.g. the reference to numbers in comment 8).

I'll try and work on localizing numbers.

Looking at the file as a whole, there are a handful of IDs that should be fixed and got missed in review (they're using CamelCase, when they should only be lowercase).

Could you elaborate?

When the content is ready, the FTL file needs to be moved in a localizable path, and all references to it updated. Currently it's in toolkit/components/aboutprocesses/content/, and not exposed for localization. For that to happen, it should move to toolkit/locales/en-US/toolkit/about/.

Ok.

Comment 12

[Francesco Lodolo [:flod]]

(In reply to David Teller [:Yoric] - last day is October 30th from comment #11)

Looking at the file as a whole, there are a handful of IDs that should be fixed and got missed in review (they're using CamelCase, when they should only be lowercase).

Could you elaborate?

We ask to only use lowercase letters and hyphens for IDs, CamelCase should be limited to files where the IDs are generated automatically, and there are a lot of them (that's the case for about:policies, for example).
https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html?highlight=lowercase

about-processes-forkServer-process-name 
about-processes-gmpPlugin-process-name 
about-processes-remoteSandboxBroker-process-name 
about-processes-webIsolated-process-name 
about-processes-webLargeAllocation 
about-processes-withCoopCoep-process-name 

These IDs should be updated, e.g. about-processes-fork-server-process-name.

Comment 13

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - get rid of camelCasing in about:processes fluent labels;r?flod

Comment 14

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Trust fluent with internationalization of CPU percentage and total duration;r?florian

Depends on D94758

Comment 15

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Trust fluent with internationalization of Memory usage and delta;r?florian

Depends on D94759

Comment 16

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Publish about:processes for localization;r?flod

Depends on D94760

Comment 17

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Let fluent internationalize duration and memory units;r?flod,florian

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d91cc348528f
get rid of camelCasing in about:processes fluent labels;r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/7abc4ea63c85
Trust fluent with internationalization of CPU percentage and total duration;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/6bc615756d14
Trust fluent with internationalization of Memory usage and delta;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/c03d67845003
Publish about:processes for localization;r=flod,fluent-reviewers

Comment 19

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_aboutprocesses_show_all_frames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ef5e2c8e4e41b9814d3d2b6abc346f5aa426957
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=320040091&repo=autoland&lineNumber=2237

Comment 20

[David Teller [:Yoric] - still alive but not very active]

This looks like a timeout.
Was this only on ASAN builds?

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/992c72ba1400
get rid of camelCasing in about:processes fluent labels;r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/426a4185018b
Trust fluent with internationalization of CPU percentage and total duration;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/825d6c917092
Trust fluent with internationalization of Memory usage and delta;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/8226dbbbacc0
Let fluent internationalize duration and memory units;r=flod,fluent-reviewers,florian
https://hg.mozilla.org/integration/autoland/rev/d6225550a9a3
Publish about:processes for localization;r=flod,fluent-reviewers

Comment 22

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_aboutprocesses_show_threads.js

backout: https://hg.mozilla.org/integration/autoland/rev/a7b7d089d5c362b8324d341eb59611829cf4087a

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=d6225550a9a3805424da1d838b79b6657a01e2bc

push where it appeared: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s%2Cbc1&test_paths=toolkit%2Fcomponents%2Faboutprocesses%2Ftests%2Fbrowser%2Fbrowser.ini&revision=2876425c75f75f638b41e8c6093e84b817938a9a

failure log: https://treeherder.mozilla.org/logviewer?job_id=320238842&repo=autoland&lineNumber=6234

[task 2020-10-30T09:48:26.428Z] 09:48:26 INFO - TEST-PASS | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_threads.js | {} == true -
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - Setting up fake process hang detector
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - Buffered messages logged at 09:48:12
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/about-processes-cpu-user-and-kernel: ReferenceError: Unknown variable: $unit."]
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - Buffered messages finished
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_threads.js | Uncaught exception - The table should be populated - timed out after 50 tries.
[task 2020-10-30T09:48:26.429Z] 09:48:26 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_threads.js | A promise chain failed to handle a rejection: [fluent][resolver] errors in en-US/about-processes-cpu-user-and-kernel: ReferenceError: Unknown variable: $unit. - stack: (No stack available.)
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - Rejection date: Fri Oct 30 2020 09:48:12 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - Stack trace:
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1100
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - Leaving test bound testShowThreads
[task 2020-10-30T09:48:26.430Z] 09:48:26 INFO - Not taking screenshot here: see the one that was previously logged

Comment 23

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Disable about:processes tests with asan;r?florian

With ASAN, we get intermittent internal timeouts. Deactivating ASAN tests.

Comment 24

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1635117 - Wait more aggressively for tab to be switched;r?florian

We encounter intermittent errors with about:processes tests during which tab switching seems to fail. This patch tweaks the tests to try harder to switch tabs.

Depends on D95308

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6359518c05a9
get rid of camelCasing in about:processes fluent labels;r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/9b72d9db5a05
Trust fluent with internationalization of CPU percentage and total duration;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/0f1b2e7e8b91
Trust fluent with internationalization of Memory usage and delta;r=florian,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/695f232f1abc
Let fluent internationalize duration and memory units;r=flod,fluent-reviewers,florian
https://hg.mozilla.org/integration/autoland/rev/53725bf4f557
Publish about:processes for localization;r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/98b2b8588747
Disable about:processes tests with asan;r=florian
https://hg.mozilla.org/integration/autoland/rev/1fee8d805e6f
Wait more aggressively for tab to be switched;r=florian

Comment 26

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6359518c05a9
https://hg.mozilla.org/mozilla-central/rev/9b72d9db5a05
https://hg.mozilla.org/mozilla-central/rev/0f1b2e7e8b91
https://hg.mozilla.org/mozilla-central/rev/695f232f1abc
https://hg.mozilla.org/mozilla-central/rev/53725bf4f557
https://hg.mozilla.org/mozilla-central/rev/98b2b8588747
https://hg.mozilla.org/mozilla-central/rev/1fee8d805e6f

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.