1635119 - Better align SharedContext/FunctionBox to ImmutableScriptFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Fix up remaining naming inconsistencies and duplicate flags. Organize the non-ImmutableScriptFlags fields of the SharedContext a little better.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635119 - Replace FunctionBox::usesArguments with ArgumentsHasVarBinding. r?mgaudet

These flags are always set to the same values by
declareFunctionArgumentsObject.

Depends on D73697

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635119 - Cleanup SharedContext::immutableFlags accessors. r?mgaudet

Use similar helper methods as js::BaseScript for consistency. Also fix the
inconsistent accessor names so they match js::BaseScript and the flag itself.

Depends on D73704

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635119 - Cleanup SharedContext/FunctionBox fields and comments. r?mgaudet

Use field initializers when possible (not on bitfields) and organize and
comment the fields better.

Depends on D73705

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5f346cd2009
Replace FunctionBox::usesArguments with ArgumentsHasVarBinding. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d9ffceaffc78
Cleanup SharedContext::immutableFlags accessors. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b80fa3c9a82f
Cleanup SharedContext/FunctionBox fields and comments. r=mgaudet

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a5f346cd2009
https://hg.mozilla.org/mozilla-central/rev/d9ffceaffc78
https://hg.mozilla.org/mozilla-central/rev/b80fa3c9a82f