Closed Bug 1635119 Opened 5 years ago Closed 5 years ago

Better align SharedContext/FunctionBox to ImmutableScriptFlags

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(3 files)

Fix up remaining naming inconsistencies and duplicate flags. Organize the non-ImmutableScriptFlags fields of the SharedContext a little better.

These flags are always set to the same values by
declareFunctionArgumentsObject.

Depends on D73697

Use similar helper methods as js::BaseScript for consistency. Also fix the
inconsistent accessor names so they match js::BaseScript and the flag itself.

Depends on D73704

Use field initializers when possible (not on bitfields) and organize and
comment the fields better.

Depends on D73705

Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5f346cd2009 Replace FunctionBox::usesArguments with ArgumentsHasVarBinding. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/d9ffceaffc78 Cleanup SharedContext::immutableFlags accessors. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/b80fa3c9a82f Cleanup SharedContext/FunctionBox fields and comments. r=mgaudet
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: