Closed
Bug 1635128
Opened 5 years ago
Closed 5 years ago
Simplify js::BaseScript flag accessors
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(2 files)
We have finished removing most of the special cases in the frontend around flag initialization and can remove more public setters from js::BaseScript.
|
Assignee | |
Comment 1•5 years ago
|
||
This adds extra asserts around the TreatAsRunOnce flag. See comment where
TreatAsRunOnce once is defined for more details.
Depends on D73706
|
|
Assignee | |
Comment 2•5 years ago
|
||
Also remove setter methods that are no longer needed.
Depends on D73713
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98be8388f69e
Cleanup BaseScript::treatAsRunOnce accessors. r=caroline
https://hg.mozilla.org/integration/autoland/rev/45f0f8d8f217
Sort the ImmutableScriptFlags accessors in js::BaseScript. r=caroline
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/98be8388f69e
https://hg.mozilla.org/mozilla-central/rev/45f0f8d8f217
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•