1635235 - Implement reading the allow override search engine allowlist from remote settings

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Once we have the code and remote settings bucket hooked up, then we should hook the two lists together.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r?daleharvey!

This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f80397bbec
Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c9f80397bbec

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1635235, Bug 1635239) for causing Bug 1640583.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e7641c1071eaadf8a74fc16c13456d4d63b367d0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303559657&repo=autoland&lineNumber=15708

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/e7641c1071ea

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1635235 - Ensure browser_ext_settings_overrides_default_search.js can wait for search engine setup to complete to avoid intermittents. r=mixedpuppy!

Depends on D76480

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f73d66ee5e8
Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/97d4e535dae5
Ensure browser_ext_settings_overrides_default_search.js can wait for search engine setup to complete to avoid intermittents. r=mixedpuppy

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8f73d66ee5e8
https://hg.mozilla.org/mozilla-central/rev/97d4e535dae5

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9483cb3c96a
Port bug 1635235 - Add defaults/settings/main/search-default-override-allowlist.json to allowed-dupes.mn. rs+a=bustage-fix