Investigate why the search engine default prompt doesn't handled dismissal as expected
Categories
(WebExtensions :: General, task, P3)
Tracking
(Not tracked)
People
(Reporter: standard8, Unassigned)
References
Details
In bug 1635235 we hit a test failure which was as a result of not being able to wait for the search engine setup to fully complete before disabling an add-on.
In https://phabricator.services.mozilla.com/D76910 we have implemented a notification that the tests may listen to, to be sure that the search engine setup has completed.
However, that promise does not currently cover the prompting to change the default search engine: https://searchfox.org/mozilla-central/rev/7dafc35406b9c945189c617d427f5458933fd3fb/browser/components/extensions/parent/ext-chrome-settings-overrides.js#391-421
We quickly tried to implement this, but the test broke when the window was closed without the prompt being closed: https://searchfox.org/mozilla-central/rev/7dafc35406b9c945189c617d427f5458933fd3fb/browser/components/extensions/test/browser/browser_ext_settings_overrides_default_search.js#139
Shane mentioned that it looks like dismissal is not being handled in the same way for the search prompt versus other code:
https://searchfox.org/mozilla-central/rev/7dafc35406b9c945189c617d427f5458933fd3fb/browser/modules/ExtensionsUI.jsm#462
https://searchfox.org/mozilla-central/rev/7dafc35406b9c945189c617d427f5458933fd3fb/browser/modules/ExtensionsUI.jsm#588
|
||
Updated•5 years ago
|
Description
•