1635365 - Move field mixed content IsSecure from BrowsingContext to WindowContext

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P1)

Description

[Christoph Kerschbaumer [:ckerschb]]

As a follow up to Bug 1575356 we should move IsSecure from BrowsingContext to WindowContext to more accurately reflect semantics of mixed content blocking.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly milestone (M6a) since this is work in progress.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1635365: Move field mixed content IsSecure from BrowsingContext to WindowContext. r=mattwoodrow

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a45d8c0fbb
Move field mixed content IsSecure from BrowsingContext to WindowContext. r=mattwoodrow

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser chrome failures on /browser_bug902156.js

backout: https://hg.mozilla.org/integration/autoland/rev/b0ef3475686e312f7313c6388eecf82b1a3af874

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Windows%2C10%2Cx64%2CQuantumRender%2Cdebug%2CMochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-3%2CM%28bc3%29&tochange=59a45d8c0fbbb218874b8a80b4b4e47c58322a38&fromchange=0fe3613ee36b6396ea8c3926530e1ed5e711afc6&selectedTaskRun=XK538KFmQE2czp--sE3tgQ-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301421711&repo=autoland&lineNumber=9005

[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_bug902156.js | Expected state for activeLoaded matches UI state -
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_bug902156.js | Expected state for passiveLoaded matches UI state -
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - Buffered messages finished
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_bug902156.js | identityBox has expected class for activeLoaded - Got false, expected true
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - Stack trace:
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/head.js:assertMixedContentBlockingState:187
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_bug902156.js:test2/<:143
[task 2020-05-08T15:34:51.504Z] 15:34:51 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:146
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_bug902156.js:test2:101
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-08T15:34:51.505Z] 15:34:51 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_bug902156.js | identityBox has expected class for activeBlocked && !passiveLoaded -

Comment 5

[Natalia Csoregi [:nataliaCs]]

It appears on other test files as well: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301422062&repo=autoland&lineNumber=11079
but they all have the same failure: The identity icon has a correct image url. - Got url("chrome://browser/skin/connection-secure.svg"), expected url("chrome://browser/skin/connection-mixed-passive-loaded.svg")

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #5)

It appears on other test files as well: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301422062&repo=autoland&lineNumber=11079
but they all have the same failure: The identity icon has a correct image url. - Got url("chrome://browser/skin/connection-secure.svg"), expected url("chrome://browser/skin/connection-mixed-passive-loaded.svg")

Thanks, I'll have a look.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c9b3cb914f3
Move field mixed content IsSecure from BrowsingContext to WindowContext. r=mattwoodrow

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9c9b3cb914f3