1635370 - Use SVG icons for the thread pane staus icons

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We use different icon sets on the platforms for the status icons in the thread pane. We should unify them and use SVG icons instead of the PNGs.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1635370-messageIcons.patch

I'm using now a shared messageIcons.css. On TagUtils.jsm I added a rule to set the fill colour for the icons to be consistent with the text colour. Some icons like junk, flag, read and new override this highlight colour when set to show their special status also in selected row state.

I deleted not only icons which aren't used any more in the thread pane but are still in the tree without usage (a lot of them are still packaged in the executables).

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9145727 [details] [diff] [review]
1635370-messageIcons.patch

Review of attachment 9145727 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great, thank you so much.
Just a little nit on a colour change.

::: mail/themes/shared/mail/messageIcons.css
@@ +161,5 @@
> +  stroke-opacity: 0;
> +}
> +
> +treechildren::-moz-tree-image(flaggedCol, flagged) {
> +  fill: #e0b63f !important; /* override the selected, focus rule */

Let's use the same fill color as the stroke: #f4bc44.
A flat and filled star looks better than with a slightly different stroke color, which creates a strange gap with the fill, mostly noticeable in dark mode (attaching screenshot later).

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2020-05-05 09-20-06.png

Here's the weird gap I see.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1635370-messageIcons.patch

The problem wasn't the colour but the fill path was too small and with the rounding errors you had transparent areas. Is this better now? For me it works now.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9145903 [details] [diff] [review]
1635370-messageIcons.patch

Review of attachment 9145903 [details] [diff] [review]:
-----------------------------------------------------------------

No more gap.
I still think that icon shouldn't have a different stroke color, especially since the variation is very minimal and "feels" strange at a quick glance.
I'm not too concern tho, so if it looks good to you, I'm okay with it.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1635370-messageIcons.patch

Made the flag icon have only one colour.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ac2e45bcc600
Use SVG icons for the thread pane staus icons. r=aleca