Closed Bug 1635370 Opened 4 years ago Closed 4 years ago

Use SVG icons for the thread pane staus icons

Categories

(Thunderbird :: Theme, task)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 78.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 2 obsolete files)

We use different icon sets on the platforms for the status icons in the thread pane. We should unify them and use SVG icons instead of the PNGs.

Attached patch 1635370-messageIcons.patch (obsolete) — Splinter Review

I'm using now a shared messageIcons.css. On TagUtils.jsm I added a rule to set the fill colour for the icons to be consistent with the text colour. Some icons like junk, flag, read and new override this highlight colour when set to show their special status also in selected row state.

I deleted not only icons which aren't used any more in the thread pane but are still in the tree without usage (a lot of them are still packaged in the executables).

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9145727 - Flags: review?(alessandro)
Comment on attachment 9145727 [details] [diff] [review]
1635370-messageIcons.patch

Review of attachment 9145727 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great, thank you so much.
Just a little nit on a colour change.

::: mail/themes/shared/mail/messageIcons.css
@@ +161,5 @@
> +  stroke-opacity: 0;
> +}
> +
> +treechildren::-moz-tree-image(flaggedCol, flagged) {
> +  fill: #e0b63f !important; /* override the selected, focus rule */

Let's use the same fill color as the stroke: #f4bc44.
A flat and filled star looks better than with a slightly different stroke color, which creates a strange gap with the fill, mostly noticeable in dark mode (attaching screenshot later).
Attachment #9145727 - Flags: review?(alessandro) → review+
Attached patch 1635370-messageIcons.patch (obsolete) — Splinter Review

The problem wasn't the colour but the fill path was too small and with the rounding errors you had transparent areas. Is this better now? For me it works now.

Attachment #9145727 - Attachment is obsolete: true
Attachment #9145903 - Flags: review?(alessandro)
Comment on attachment 9145903 [details] [diff] [review]
1635370-messageIcons.patch

Review of attachment 9145903 [details] [diff] [review]:
-----------------------------------------------------------------

No more gap.
I still think that icon shouldn't have a different stroke color, especially since the variation is very minimal and "feels" strange at a quick glance.
I'm not too concern tho, so if it looks good to you, I'm okay with it.
Attachment #9145903 - Flags: review?(alessandro) → review+

Made the flag icon have only one colour.

Attachment #9145903 - Attachment is obsolete: true
Attachment #9146074 - Flags: review+
Target Milestone: --- → Thunderbird 78.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ac2e45bcc600
Use SVG icons for the thread pane staus icons. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.