1635432 - Create FunctionBox without a FunctionCreationData

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

A FunctionBox now tracks all the info it needs to allocate a JSFunction without needing a FunctionCreationData. This bug is about being able to create the FunctionBox with only a default FunctionCreationData and to allocate the deferred JSFunction directly from FunctionBox.

Future work will cleanup CompilationInfo::funcData so that we can eliminate the FunctionCreationData entirely and use ScriptStencil instead.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635432 - Create FunctionBox without a FunctionCreationData. r?mgaudet

Initialize the FunctionBox fields from parameters instead of a
FunctionCreationData instance, and allow creating the JSFunction directly
from the FunctionBox. This allows us to remove most fields from the
FunctionCreationData type.

Note that we still use a default instance of FunctionCreationData to
correctly fill in CompilationInfo::funcData list. Future work will address
that when we unify with ScriptStencil.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c31cfefcd2d
Create FunctionBox without a FunctionCreationData. r=mgaudet

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c31cfefcd2d