1618636 - Unify FunctionCreationData and BCEScriptStencil into a single structure

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

By the end of Stencil, we need to distinguish much less the difference between a JSFunction and JSSCript, because from the perspective they're two pieces of the same thing (where the Script is an optional addition to a function)

We should unify them to make this clear, probably in a similar way to how we made FunctionCreationData own the LazyScriptCreationData.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1618636 - Add non-virtual ScriptStencilBase. r?mgaudet

Add a plain base class to hold the ScriptStencil data members. This
non-virtual type will later be used to replace FunctionCreationData. In the
long run we will remove the virtual methods entirely.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1618636 - Remove the Maybe in FunctionCreationData. r?mgaudet

Add a FunctionBox::emitLazy flag to identify boxes which should allocate a
lazy script. This also is used to avoid allocating JSFunctions for funboxes
that are the result of a failed syntax parse.

Depends on D74155

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1618636 - Move FunctionCreationData::createLazyScript. r?mgaudet

Depends on D74156

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1618636 - Replace FunctionCreationData with ScriptStencilBase. r?mgaudet

We only use the gcThings array, but this is a stepping stone to Stencil.

Depends on D74157

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0531f5d899fd
Add non-virtual ScriptStencilBase. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/eae61ee67546
Remove the Maybe in FunctionCreationData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/bef58cfccdd8
Move FunctionCreationData::createLazyScript. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3a21ee384f6d
Replace FunctionCreationData with ScriptStencilBase. r=mgaudet

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0531f5d899fd
https://hg.mozilla.org/mozilla-central/rev/eae61ee67546
https://hg.mozilla.org/mozilla-central/rev/bef58cfccdd8
https://hg.mozilla.org/mozilla-central/rev/3a21ee384f6d