1635568 - Split-out event listeners from observer classes

Status: RESOLVED WONTFIX

(Remote Protocol :: Agent, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

At least the ContextObserver and TabObserver classes use a mixture of observers and event listeners. While observer notifications should only be registered once (because those are global and mainly live in the parent process), the events are tight to the current tab's content (docShell).

As such both methods need to be split apart. Also this will be needed for being Fission compatible.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that assigning myself to this bug and making it beta-reserve, it causes problems with the MVP selection. So I will check for a workaround similar to Maja's navigation work.

Comment 2

[Neha Kochar [:neha]]

Henrik, could you please find an assignee for this?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Neha Kochar [:neha] from comment #2)

Henrik, could you please find an assignee for this?

It's currently not clear if we have to solve this bug or not. It all depends on discussions, which will happen over the next weeks. It's basically not clear if we want to make Remote Agent Fission compatible or not, given that WebDriver BiDi is coming up and will replace it.

Comment 4

[Neha Kochar [:neha]]

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Neha Kochar [:neha] from comment #4)

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

In that case, setting Fission Milestone to Future to remove this bug from our Fission triage list.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In our new WebDriver BiDi implementation we also register observers per window global. That makes it easier for filtering and was also proposed by DOM peers. As such we shouldn't need this particular bug.