Closed
Bug 1635635
Opened 5 years ago
Closed 5 years ago
Use ScriptThingsVector for FunctionCreationData
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(2 files)
In order to remove the FunctionCreationData, we should first move the lazy script data into the ScriptThingsVector type. This make this compatible with ScriptStencil in the future.
|
Assignee | |
Comment 1•5 years ago
|
||
This patch is just code motion for the next one.
Depends on D73883
|
|
Assignee | |
Comment 2•5 years ago
|
||
Use ScriptThingVariant to represent closed-over-bindings and inner-functions
for lazy functions. Inline the body of BaseScript::CreateLazy as well so we
can use EmitScriptThingsVector to init the gcthings. We take care to keep
setting the enclosingScript link.
Depends on D74035
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6afc1e17a01
Move definition of FunctionCreationData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/2e63b0061d2e
Use ScriptThingsVector for FunctionCreationData. r=mgaudet
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f6afc1e17a01
https://hg.mozilla.org/mozilla-central/rev/2e63b0061d2e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•