1635757 - [Wayland] Dragging and dropping tab outside application windows does not create new window for tab sometimes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1527976#c47
The D&D still fails sometime.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1635757 [Wayland] Provide more logging to nsDragService, r?jhorak

Comment 2

[Thomas Deutschmann]

Attachment: ff76_moz_log_nsDragService5-r2.log

New log with your patch applied.

On first drag&drop attempt I tried to drag a tab on some free space on the right of the window which failed. The second attempt was a drag&drop to the bottom again which seems to work reliable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/243019d57985
[Wayland] Provide more logging to nsDragService, r=jhorak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/243019d57985

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Thanks. From the log it looks like drag service part works as expected, I'd need to look at some D&D internals.

Comment 6

[Ferdinand Mütsch]

Any updates here? I'm still having the same bug. And I don't know if it's related, but I also can't drag bookmarks in the bookmark manager to change their position.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1635757 [Linux] Remove nsDragService logging module and log D&D with WidgetDrag log module, r?jhorak

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Looking at it. Seems to be a race condition when wayland quits the D&D before Firefox manages to get the result so it's canceled from the compositor side.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1635757 [Wayland] Set MOZ_GTK_DRAG_RESULT_NO_TARGET in invisibleSourceDragFailed, r?jhorak

Comment 10

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47f4435ac2e930760b5d409e7adc7e04101a354d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1462ad0a83df
[Linux] Remove nsDragService logging module and log D&D with WidgetDrag log module, r=jhorak

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a1c138bb7e4
[Wayland] Set MOZ_GTK_DRAG_RESULT_NO_TARGET in invisibleSourceDragFailed, r=jhorak

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1462ad0a83df
https://hg.mozilla.org/mozilla-central/rev/3a1c138bb7e4

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Should be fixed now, Thanks.

Comment 15

[gliu20]

Hi there, this is my first time reporting a bug, so do let me know if this isn't the right place.

I'd like to point out that I'm still having this issue in firefox on Ubuntu (Linux 5.8.0-59-generic #66~20.04.1-Ubuntu SMP Thu Jun 17 11:14:10 UTC 2021).

Name Firefox
Version 89.0.2
Build ID 20210622155641

It seems like dragging with the mouse works as long as windows are not maximized, but fails once windows are maximized. I should point out that I added the following environment variable to my ~/.profile file to enable touch in firefox:

export MOZ_ENABLE_WAYLAND=1

Comment 16

[Darkspirit]

bug 1719894 is about remaining problems.