1719894 - [wayland] Dragging a tab from a window's tab strip doesn't create a new window

Status: RESOLVED DUPLICATE of bug 1729423

(Core :: Widget: Gtk, defect, P2)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: example STR

STR:

• Launch Firefox with Wayland enabled (MOZ_ENABLE_WAYLAND=1)
• Open a new tab, drag it out of the window's tab strip, and release

Expected Results:

• A new browser window is created and the dragged tab is moved into it

Actual Results:

• The drag appears to be cancelled

I've attached a video of the issue being reproduced on Fedora 34 (GNOME 40.1.0)

Comment 1

[Robert Mader [:rmader]]

FWIW, I can reproduce a certain flakyness, i.e. it sometimes works and sometimes not. We might be able to better, but to make things work really reliable we'll probably need https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/46

Comment 2

[Drew]

I have been experiencing the same issue since I started using wayland 1-2 months ago, but it is not flaky. It fails 100% of the time.

firefox 90.0.2
mutter 40.3

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Can you please try latest nightly with async clipboard? (https://bugzilla.mozilla.org/show_bug.cgi?id=1725149#c5).
Thanks.

Comment 4

[Andrew Gaul]

I can confirm that this is fixed when enabling widget.wayland.async-clipboard.enabled with 93.0a1 (2021-08-13). Thanks :stransky!

Comment 5

[Drew]

I'll give it a shot as soon as the nightly package is updated for my distro. https://aur.archlinux.org/packages/firefox-nightly/

Comment 6

[Nika Layzell [:nika] (ooo, ni? for response)]

With the widget.wayland.async-clipboard.enabled pref enabled on the 2021-08-16 build and Fedora 34, this bug appears to be fixed. It no longer appears that having a tiled or maximized window prevents tabs from being dragged out, awesome!

I did notice some issues with the placement of the new window created when this is done, though, which I've reported as a separate bug (bug 1725979).

Comment 7

[Drew]

93.0a1 (2021-08-21) (64-bit)
widget.wayland.async-clipboard.enabled = true

I'm still having the same problem as firefox 91.

I figured out there is a way to get it to work in both 91 and 93. First of all the window cannot be maximized or touching the upper edge of the screen. Then I have to quickly drag a tab to the top edge of the same monitor the window is on, let it collide with the top edge, and then release the mouse button quickly. If I time it perfectly, I actually get a new window from the tab. This works for me about 1 time out of 10.

Comment 8

[rsgreen]

91.0 (64-bit), Fedora 34
widget.wayland.async-clipboard.enabled = true

I am experiencing the same behavior. I attempted the "technique" noted above by Drew and it worked. I did not, however, have to drag the tab to the top edge. Repeatedly dragging a tab to the desktop usually results in a new window being opened at least 1x in 10 tries. Also, as Drew noted, the original window cannot be touching any edges of the current screen and speed counts. The faster the drag+release operation is performed, the higher the success rate.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Can you run Firefox with MOZ_LOG="WidgetDrag:5", reproduce the issue with latest nightly & widget.wayland.async-clipboard.enabled = true and attach the log here?
Thanks.

Comment 10

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: WidgetDrag=5 logs for successful drag & drop as requested in comment 9

(In reply to Martin Stránský [:stransky] (ni? me) from comment #9)

Can you run Firefox with MOZ_LOG="WidgetDrag:5", reproduce the issue with latest nightly & widget.wayland.async-clipboard.enabled = true and attach the log here?
Thanks.

As I said in comment 6, I no longer reproduce this specific issue (being unable to drag out the tab) after setting widget.wayland.async-clipboard.enabled = true & restarting the browser on the latest nightlies, however I reproduce a different issue (bug 1725979). I've attached a text file with the WidgetDrag:5 log for dragging a tab out of a window (which works successfully, other than the new window being placed incorrectly)

Interestingly, as I have discovered when composing this comment, I cannot copy/paste text from Firefox anymore, and have had to use drag & drop to move text between text fields to write this comment.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Async clipboard is enabled by default now.