1635809 - Fix github-sync to properly sync file deletions

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1635430 I deleted the appveyor.yml file for webrender in m-c. It didn't get synced over to github properly; the change got squashed into the commit at https://github.com/servo/webrender/commit/28043d40439f08a3b2d41a1260cee729e8ffb45d instead of getting its own commit. That is wrong, need fixing.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1635809 - Update readme.md to include some semblance of debugging instructions. r?kvark

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1635809 - Prevent crash in converter.py on debug output with non-ascii hg log data. r?kvark

This is just in debug output, so the fact that we ignore non-utf-8 chars is ok.

Depends on D74064

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1635809 - Use |file| instead of |modifies| in the hg revset query to catch file deletions. r?kvark

Closer look at the man pages shows that the file() query will catch any file
changes, whereas the modifies() query will only capture files that were
modified, which excludes strict deletions.

Depends on D74065

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbf2526b2fb1
Update readme.md to include some semblance of debugging instructions. r=kvark
https://hg.mozilla.org/integration/autoland/rev/42188f92fb38
Prevent crash in converter.py on debug output with non-ascii hg log data. r=kvark
https://hg.mozilla.org/integration/autoland/rev/066910bce3e5
Use |file| instead of |modifies| in the hg revset query to catch file deletions. r=kvark

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bbf2526b2fb1
https://hg.mozilla.org/mozilla-central/rev/42188f92fb38
https://hg.mozilla.org/mozilla-central/rev/066910bce3e5