1635923 - Implement multiword search for address book sidebar / select addresses dialog

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)

Description

[Ian Neal]

STR (Taken from Bug 1000775)

1. have AB contact card with

• Display name: "Doe, John" (without quotes)
• email: "[e-mail]"

2. compose new msg, F9 to open contacts side bar for step 3b)
   3a) in recipient pane with autocompletion, type:
   John Doe
   3b) in AB quick search (address book sidebar or Options -> Select Addresses), type:
   John Doe

Actual result
3a) recipient autocomplete uses john AND doe algorithm, hence successfully finds "Doe, John" (good)
3b) AB quick search uses john doe algorithm, hence finds nothing (this bug)

Expected result
3b) Should be the same as in 3a, "Doe, John" contact should be found and offered in the AB quick search results list. E.g. for intuitive basic searches like "John Doe", all matching cards should be found regardless where exactly in any field these words are present or contained.

At the same we should implement a mechanism (e.g. quoting) to search for whole string as typed, including spaces, so that "word1 word2" matches all cards what have "word1 word2" in one of their searched fields.

Port the relevant parts of the following bugs to SeaMonkey:

• Bug 1000775 - For AB Quicksearch / contacts side bar, implement split multiword search pattern
• Bug 1091675 - Implement quoting to disable multi-word search in addressbook

Comment 1

[Ian Neal]

Attachment: Implement AB multiword search

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: inconsistent search behaviour
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9146310 [details] [diff] [review]
Implement AB multiword search

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f349036e7311
Implement multiword search for address book sidebar / select addresses dialog. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6cd74a7ad7e15914faaa2d588bddb7eade4ac40d