1636073 - 2 /html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/ tests are expected TIMEOUT

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am going through all the tests in web-platform-tests which are expected TIMEOUT and found 2 tests in shared-array-buffers:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https.html

this test:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html

passes all the subtests and the harness times out. No information is available in the console.

this test:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https.html

doesn't pass/run anything and times out on the first test:
SharedArrayBuffer cannot cross agent clusters, shared worker edition

:hsinyi, can you help figure out or find someone who can why these tests are failing and if we need to fix the tests, the product, or acknowledge a feature isn't supported?

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We haven't shipped SharedArrayBuffer yet. We are going to re-enable it, see https://bugzilla.mozilla.org/show_bug.cgi?id=1606624
NI Tom to see if he has more to share about these specific tests.

Comment 2

[Tom Tung [:tt, :ttung]]

I don't have anything to add now, but I will bring this to the meeting tomorrow (for checking if these tests block shipping the SAB to Release). Thanks!

I will update the result here and cancel the needinfo then.

Comment 3

[Tom Tung [:tt, :ttung]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #0)

I am going through all the tests in web-platform-tests which are expected TIMEOUT and found 2 tests in shared-array-buffers:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https.html

this test:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html

passes all the subtests and the harness times out. No information is available in the console.

I overlooked this. It's probably because the data url tests are time out. I will update the expectation once I verify it.

this test:
/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https.html

I will check this later.

Comment 4

[Tom Tung [:tt, :ttung]]

The reason that window-sharedworker-failure.https.html is that:

• SharedBuffer cannot be created for the shared workers.

It's not clear to me why we don't have this issue on serivce workers and I will check that.

There are a few things we need to do to fix this issue:

• We should check COEP for the value of this.crossOriginIsoalted for workers
• To check COEP for workers, we need to do some structure change because we construct a WorkerPrivate, propagate this.crossOriginIsoalted to JS engine and then load the script.
  It means that we only know the COEP when loading worker script. And we might need a way to predict or guess the value of COEP while constructing the worker private object to propagate it to the JS engine.

While we are fixing this, we should probably isolate the SharedWorkers and ServiceWorkers from normal processes when they are in cross-origin isolated environment.

Comment 5

[Tom Tung [:tt, :ttung]]

In other words, I guess we should file bugs for:

• Checking COEP on workers for this.crossOriginIsolated
• Isolate shared workers and service workers in special processes if their this.crossOriginIsolated is true.
• Ensure propagate the correct value into JS engine while constructing the worker private.

If we fix them, this test should be fixed.

Comment 6

[Anne (:annevk)]

Bug 1613912 is tracking that effort.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

:ttung, this looks like a lot of work that will take a few weeks or even a couple months, should we mark these 2 tests as backlog (not yet implemented but planned to?)

Comment 8

[Anne (:annevk)]

Joel, that sounds reasonable to me. If you do that, could you please add a comment to bug 1613912 indicating the .ini files that need to be removed as part of fixing it?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1636073 - mark 2 shared array buffer tests as backlog (tier-2). r=jgraham

mark 2 shared array buffer tests as backlog (tier-2)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a0d743a5628
mark 2 shared array buffer tests as backlog (tier-2). r=jgraham

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7a0d743a5628