1606624 - Ship SharedArrayBuffer (and atomics) to Release (potentially with throwing postMessage())

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Anne (:annevk)]

Despite the similar title, this is a vast subset of bug 1477743 as it only pertains flipping javascript.options.shared_memory and not COOP/COEP. Ideally we ship this in Firefox 75 having had one Beta cycle in 74 and one Nightly cycle in 73 (currently happening). Also:

1. All dependencies will need to have been fixed.
2. To repeat, bug 1599496 will need to have been fixed and we should have had at least one beta cycle.
3. There should be an "intent to ship" to dev-platform that explains that this is not a security threat as it doesn't add much beyond what ArrayBuffer can already do (postMessage() will likely still throw as I suspect we won't be ready to ship COOP/COEP yet).

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1606624 - Changes on interface tests in mochitest;

Comment 2

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71cb44ff5662042b7b8cc96251572fff64f55b9a
late beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d399afd06b7c0ff3bce42c517e0f23c7412d34f4

Comment 3

[Anne (:annevk)]

Due to renewed discussion in https://github.com/whatwg/html/issues/4732 we'll be waiting a bit with this until that's resolved.

Comment 4

[Anne (:annevk)]

FWIW, there's no longer a dependency on fixing the JavaScript test failures. The WebVM team has investigated them and will fix them, but they also clarified they should not block shipping.

Comment 5

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a6e41ca2d476bb0de85b1c6eac87b6a7331aeb

Comment 6

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #5)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a6e41ca2d476bb0de85b1c6eac87b6a7331aeb
I forgot to rebase the patch on the top of m-c when I pushed it. Please ignore the JS ref tests failures on it

try on the top of the latest m-c : https://treeherder.mozilla.org/#/jobs?repo=try&revision=55fcbbd93c7af238fe852ff0bc1fdcad49263ed9

Comment 7

[Tom Tung [:tt, :ttung]]

Here is late beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=187db225af6ced5752047c82e67a88f21c9dcb79

I expect there might have some wpt failures that are caught by the patch.

Comment 8

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #7)

Here is late beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=187db225af6ced5752047c82e67a88f21c9dcb79

I expect there might have some wpt failures that are caught by the patch.

Another try push for late beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dffea186d461754c4443fdd3686a1a883ad3cefd&selectedTaskRun=UU76E4Z_SAeh9gQ0C2gF4A-0

There are some test failures for jit-test (wasm), but the error messages of them don't look like to be related to this change.

Comment 9

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1606624 - Changes on web-platform tests;

Depends on D66777

Comment 10

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1606624 - Changes on a xpconnect test;

Depends on D74596

Comment 11

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1606624 - Ship SharedArrayBuffer (and atomics) to Release;

Depends on D74597

Comment 12

[Lars T Hansen [:lth]]

(In reply to Tom Tung [:tt, :ttung] from comment #8)

There are some test failures for jit-test (wasm), but the error messages of them don't look like to be related to this change.

Yes, bug 1635783 mostly. Working on that.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab75def8357
Changes on interface tests in mochitest; r=jwalden
https://hg.mozilla.org/integration/autoland/rev/b6cfb3f327c0
Changes on web-platform tests; r=annevk
https://hg.mozilla.org/integration/autoland/rev/99e0c196fab5
Changes on a xpconnect test; r=lth
https://hg.mozilla.org/integration/autoland/rev/4cf97e56be1b
Ship SharedArrayBuffer (and atomics) to Release; r=annevk

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2ab75def8357
https://hg.mozilla.org/mozilla-central/rev/b6cfb3f327c0
https://hg.mozilla.org/mozilla-central/rev/99e0c196fab5
https://hg.mozilla.org/mozilla-central/rev/4cf97e56be1b

Comment 15

[Kohei Yoshino]

Hmm wait, this change is supposed to be postponed due to COVID-19. Please stop by Slack channel #breaking-changes-review.

Comment 16

[Anne (:annevk)]

It seems I mistakenly added this to bug 1625822.

Comment 17

[Florian Scholz (Open Web Docs)]

Updated/written docs:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Opener-Policy

Fx 79 release notes announcements:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/79#JavaScript
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/79#HTTP

If anyone has more feedback on these docs, please comment on https://github.com/mdn/sprints/issues/2219 where we've been discussing this a bit already.