Closed Bug 1606624 Opened 1 year ago Closed 1 year ago

Ship SharedArrayBuffer (and atomics) to Release (potentially with throwing postMessage())

Categories

(Core :: DOM: Core & HTML, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: annevk, Assigned: tt)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(4 files)

Despite the similar title, this is a vast subset of bug 1477743 as it only pertains flipping javascript.options.shared_memory and not COOP/COEP. Ideally we ship this in Firefox 75 having had one Beta cycle in 74 and one Nightly cycle in 73 (currently happening). Also:

  1. All dependencies will need to have been fixed.
  2. To repeat, bug 1599496 will need to have been fixed and we should have had at least one beta cycle.
  3. There should be an "intent to ship" to dev-platform that explains that this is not a security threat as it doesn't add much beyond what ArrayBuffer can already do (postMessage() will likely still throw as I suspect we won't be ready to ship COOP/COEP yet).
Depends on: 1613424
Depends on: 1613740
No longer depends on: 1613424
No longer depends on: 1613740
Blocks: 1619649

Due to renewed discussion in https://github.com/whatwg/html/issues/4732 we'll be waiting a bit with this until that's resolved.

No longer depends on: 1598612
Depends on: 1624266
No longer depends on: 1599295

FWIW, there's no longer a dependency on fixing the JavaScript test failures. The WebVM team has investigated them and will fix them, but they also clarified they should not block shipping.

Blocks: COVID-19
Depends on: 1630877

(In reply to Tom Tung [:tt, :ttung] from comment #5)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2a6e41ca2d476bb0de85b1c6eac87b6a7331aeb
I forgot to rebase the patch on the top of m-c when I pushed it. Please ignore the JS ref tests failures on it

try on the top of the latest m-c : https://treeherder.mozilla.org/#/jobs?repo=try&revision=55fcbbd93c7af238fe852ff0bc1fdcad49263ed9

Here is late beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=187db225af6ced5752047c82e67a88f21c9dcb79

I expect there might have some wpt failures that are caught by the patch.

(In reply to Tom Tung [:tt, :ttung] from comment #7)

Here is late beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=187db225af6ced5752047c82e67a88f21c9dcb79

I expect there might have some wpt failures that are caught by the patch.

Another try push for late beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dffea186d461754c4443fdd3686a1a883ad3cefd&selectedTaskRun=UU76E4Z_SAeh9gQ0C2gF4A-0

There are some test failures for jit-test (wasm), but the error messages of them don't look like to be related to this change.

Attachment #9133205 - Attachment description: Bug 1606624 - Ship SharedArrayBuffer (and atomics) to Release; → Bug 1606624 - Changes on interface tests in mochitest;

Depends on D66777

Depends on D74596

(In reply to Tom Tung [:tt, :ttung] from comment #8)

There are some test failures for jit-test (wasm), but the error messages of them don't look like to be related to this change.

Yes, bug 1635783 mostly. Working on that.

Status: NEW → ASSIGNED
Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab75def8357
Changes on interface tests in mochitest; r=jwalden
https://hg.mozilla.org/integration/autoland/rev/b6cfb3f327c0
Changes on web-platform tests; r=annevk
https://hg.mozilla.org/integration/autoland/rev/99e0c196fab5
Changes on a xpconnect test; r=lth
https://hg.mozilla.org/integration/autoland/rev/4cf97e56be1b
Ship SharedArrayBuffer (and atomics) to Release; r=annevk

It seems I mistakenly added this to bug 1625822.

No longer blocks: COVID-19
You need to log in before you can comment on or make changes to this bug.