1636148 - Make calling nsIPrincipal->GetURI a clang-error

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Sebastian Streich [:sstreich]]

We've come far to remove all Callsites of Geturi in "c-land". To make shure no new callers can be added until we we've cleaned up js land (and thus can just remove the interface) - I want to change the clang plugin to produce a build error instead of a warning.

Comment 1

[Sebastian Streich [:sstreich]]

Attachment: Bug 1636148 - "BandAid" - Cast Remaining Callers To BasePrincipal r=ckerschb

Comment 2

[Sebastian Streich [:sstreich]]

Attachment: Bug 1636148 - Disable Building Principal->GetURI r=ckerschb

Depends on D74248

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fda7ca2484d
"BandAid" - Cast Remaining Callers To BasePrincipal r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/fca4a9808bd9
Disable Building Principal->GetURI r=ckerschb

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1636148) for Build bustage on android in gecko/widget/android/nsWindow.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301909053&repo=autoland&lineNumber=35498

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=fca4a9808bd9bc213b97b11d3bc81e19c551fb93

Backout:
https://hg.mozilla.org/integration/autoland/rev/46ade2ec123e746d2fd85de94b0ffde6e41a6079

Comment 5

[Sebastian Streich [:sstreich]]

Sorry! should work now :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b328a689b674
"BandAid" - Cast Remaining Callers To BasePrincipal r=ckerschb,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/1a7e54a71d1d
Disable Building Principal->GetURI r=ckerschb

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b328a689b674
https://hg.mozilla.org/mozilla-central/rev/1a7e54a71d1d