1638288 - Builds busted (if clang-plugin enabled): mailnews/base/src/nsMsgContentPolicy.cpp:155:23: error: Principal->GetURI is depricated and will be removed soon. Please consider using the new helper functions of nsIPrincipal

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P1)

Description

[Magnus Melin [:mkmelin]]

Builds are busted with clang-plugin enabled.

mailnews/base/src/nsMsgContentPolicy.cpp:155:23: error: Principal->GetURI is depricated and will be removed soon. Please consider using the new helper functions of nsIPrincipal.

From bug 1636148 - https://hg.mozilla.org/mozilla-central/rev/1a7e54a71d1d17416b7351dea51db84f936b27d0

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1638288 - don't use nsIPrincipal->GetURI for Thunderbird. r=ckerschb

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1638288_principal_uri.patch

The c-c part.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: [checked in] bug1638288_principal_uri.patch

Needed another fix too to fix some tests (at least). Apparently comparing principal.equals(null) isn't liked anymore. E.g. comm/mail/components/addrbook/test/browser/browser_contact_tree.js and comm/mail/test/browser/account/browser_values.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8d9cd134ff9
Temporarily disable clang-plugin. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/091c930b9c4d
Port Bug 1636148 - Make calling nsIPrincipal->GetURI a clang-error. rs=bustage-fix DONTBUILD

Comment 5

[Magnus Melin [:mkmelin]]

(The typo that was in the summary is in the code, don't change.)

Comment 6

[Ben Campbell]

On that last change:

-    rv = aRequestPrincipal->GetURI(getter_AddRefs(originatorLocation));
+    BasePrincipal::Cast(loadingPrincipal)->GetURI(getter_AddRefs(originatorLocation));

Is this right? Looking at the original version, should it be:

BasePrincipal::Cast(aRequestPrinciple)->GetURI(getter_AddRefs(originatorLocation));

?

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1638288_cc_followup_principal.patch

Indeed, that was wrong!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ba221cc0eb4
fix mistake in previous patch. r=benc

Comment 9

[Ben Campbell]

Figured we should keep this open until the M-C part of the fix lands ( D75535 ).

Comment 10

[Intermittent Failures Robot]

6 failures in 5488 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 6

Platform breakdown:

• macosx1014-64: 1
• windows2012-64-shippable: 1
• linux64-shippable: 1
• osx-shippable: 1
• windows2012-32-shippable: 1
• linux32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1638288&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dd5b0c8f80b
don't use nsIPrincipal->GetURI for Thunderbird. r=ckerschb

Comment 12

[mac198442]

OK now that the patch is approved and autoland is open, could we get this landed?

Comment 13

[Magnus Melin [:mkmelin]]

Not yet, it needs to be merged to mozilla-central first.

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9dd5b0c8f80b

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a440d58f09f8
re-enable clang-plugin - back out changeset b8d9cd134ff9. rs=me