1636428 - Add pref/warning to remove accent property from the operator dictionary and change its default to true

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang Nélar]

Attachment: accent.html

This was removed from MathML Core: https://github.com/mathml-refresh/mathml/issues/151#issuecomment-596040584 and the default value changed to "true".

The rationale is that when operators that are used as overscript, they are likely to be accents. In other situations, the accent property is irrelevant, so it does not hurt to make all operators accent by default.

See the attached testcase showing two operators that currently have different default accent properties. Font-size is not scaled down for accent overscripts.

Accent property is specified in the operator dictionary:
https://searchfox.org/mozilla-central/source/layout/mathml/mathfont.properties

and is set/used in the MathML code:
https://searchfox.org/mozilla-central/search?q=ACCENT&case=true&path=layout%2Fmathml

It would be good to deprecate/remove the accent property from the operator dictionary, to prepare for a compact form for the operator dictionary currently being developed:
https://mathml-refresh.github.io/mathml-core/#operator-dictionary-compact

(this would replace this mathfont.properties text file loaded dynamically as a huge hash table)

Comment 1

[eri]

Attachment: Bug 1636428 - Deprecate accent property from the operator dictionary r?emilio,fredw

Disables parsing of the accent property in the dictionary if
mathml.operator_dictionary_accent.disabled is on.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5e1af578431
https://hg.mozilla.org/integration/autoland/rev/8effd84db876
Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3e23b9c45ea
https://hg.mozilla.org/integration/autoland/rev/4690cabc63c8
Revert "Bug 1636428 - Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod" for causing multiple failures

Comment 4

[amarc]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log -> build bustage
• Failure Log 2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e6abf8f3d9f5
https://hg.mozilla.org/integration/autoland/rev/31e4ff33d254
Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56668479f215
https://hg.mozilla.org/integration/autoland/rev/c8f6634189ff
Revert "Bug 1636428 - Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod" for causing bc failures @ browser_misused_characters_in_strings.js

Comment 7

[amarc]

Backed out for causing bc failures @ browser_misused_characters_in_strings.js

• Backout link
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c11ffaf4707
https://hg.mozilla.org/integration/autoland/rev/7768a956b4a2
Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b27997d294f4
https://hg.mozilla.org/integration/autoland/rev/066bcbb4575a
Revert "Bug 1636428 - Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod" for causing mathml-console-messages.html

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/066bcbb4575a7287678be02ba16a6d349a730875

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | /_mozilla/mathml/mathml-console-messages.html

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/374e8d529b65
https://hg.mozilla.org/integration/autoland/rev/9697cf9053ff
Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa485df7c4f7
https://hg.mozilla.org/mozilla-central/rev/4cf515ecaa18
Deprecate accent property from the operator dictionary r=emilio,fredw,layout-reviewers,flod

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4cf515ecaa18

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9697cf9053ff