1636496 - Microphone icon never goes away

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Drew]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Participated in a video chat with google hangouts. Ended the call and closed the tab.

Actual results:

A box pops up on the top of my screen with a firefox icon and a microphone icon. When I end the call, the firefox icon remains, hovering over my windows and never closes until I completely exit firefox.

Expected results:

Entire popup should go away when the call ends.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity is normal and has not been changed, and this bug's priority is -- (none,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Dan Minor [:dminor]]

It's definitely possible something has changed on the WebRTC side to break this, but I think it makes sense to investigate this on the Site Permissions side first.

Comment 5

[Emma Zühlcke [:emz]]

I was able to reproduce this on todays Nightly on Google Hangouts / Meet on Linux. Didn't find a specific regression range with mozregression though.
There is no exception thrown in the console unless I click the webrtc sharing indicator. Then it throws because there are no active streams in the array which webrtcUI.getActiveStreams returns here: https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/browser/base/content/webrtcIndicator.js#142-143
The indicator disappears when I close the the parent tab (which originally launched the popup with the video call).

Comment 6

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

I believe folks are seeing this on SUMO in Firefox 77. I have tagged the SUMO support questions: #microphoneicon77 and #bug1636496

Comment 7

[Emma Zühlcke [:emz]]

Attachment: Bug 1636496 - Only show global sharing indicator window if we have a media indicator to show. r=johannh

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Don't know if a regression range is still required since I see that Paul already has a patch but I did found a regression between the nightly builds from 2020-01-10:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=feb7d997f96164b028c9cf57a74878095cdad0d3&tochange=12bf9dc0978e049c367ba4c22052569c3acb1e50 (not sure of the potential regressor there)

I tried to dig deeper with mozregression but I got mixed results every time so it's not reliable. Hope this helps.

Comment 9

[Emma Zühlcke [:emz]]

Thanks for looking into this! I assume this is the regression: https://hg.mozilla.org/mozilla-central/rev/99dbe196e0a62bf13ad87b212fedfee894c8a28e#l12.329

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed52478a359
Only show global sharing indicator window if we have a media indicator to show. r=johannh

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1ed52478a359

Comment 13

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Bogdan Maris, Desktop Test Engineering]

Verified that this is fixed in latest Firefox Beta 79.0b3 on Ubuntu 18.04 64bit.