Make URLSearchParams not structured-cloneable
Categories
(Core :: DOM: Core & HTML, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: baku, Assigned: janv)
References
(Blocks 2 open bugs)
Details
(Keywords: site-compat)
Attachments
(2 files, 2 obsolete files)
Updated•4 years ago
|
Reporter | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Reporter | ||
Comment 3•4 years ago
|
||
Comment 4•4 years ago
|
||
We decided to wait with fixing this until post Covid-19 as there are some weird interactions with IDB (retrieving data would throw). And while probably nobody runs into that in practice, it's not worth the additional hassle at this point for the person that might.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Comment on attachment 9147359 [details]
Bug 1636761 - URLSearchParams serialized for XHR in workers, r?smaug
Revision D74712 was moved to bug 1637857. Setting attachment 9147359 [details] to obsolete.
Updated•4 years ago
|
Comment 6•2 years ago
|
||
I found this bug because of this comment: https://github.com/mdn/content/issues/21178#issuecomment-1264062972
Is it time to pick this back up?
Comment 7•2 years ago
|
||
I created https://github.com/web-platform-tests/wpt/pull/37994 to test that this isn't supported.
Updated•2 years ago
|
Comment 9•1 year ago
|
||
Updated•1 year ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Comment 10•8 months ago
|
||
Hi Jens,
It seems the main issues with the patch landing are related to the indexeddb use.
Could the LWS team take this bug as part of the interop 2024 effort for indexeddb?
Comment 11•8 months ago
|
||
Jan is going to take a look.
Updated•8 months ago
|
Assignee | ||
Comment 12•8 months ago
|
||
URLSearchParams already stored in IndexedDB can't be easily removed. So instead
of doing potentially massive database upgrade, URLSearchParams objects are
deserialized as empty objects from now on.
Depends on D199344
Updated•8 months ago
|
Assignee | ||
Updated•8 months ago
|
Updated•8 months ago
|
Updated•7 months ago
|
Comment 13•7 months ago
|
||
Pushed by bugmail@asutherland.org: https://hg.mozilla.org/integration/autoland/rev/8a34c69baa2f Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/e19167a91657 Make URLSearchParams not structured-cloneable, r=asuth,webidl
Comment 14•7 months ago
|
||
Backed out for causing mochitests failures in test_structuredCloneAndExposed.html.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/whatwg/test_structuredCloneAndExposed.html | Test timed out. -
Assignee | ||
Updated•7 months ago
|
Comment 15•7 months ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcc9567f3950 Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth
Comment 16•7 months ago
•
|
||
Backed out for causing xpcshell failures in test_URLSearchParams.js.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | xpcshell.toml:dom/indexedDB/test/unit/test_URLSearchParams.js | xpcshell return code: 0
Assignee | ||
Comment 17•7 months ago
|
||
For some unknown reason the new test failed on autoland, but it works on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=65a83ad4219f59c3c9cb256f85f022b65c125fed
Assignee | ||
Comment 18•7 months ago
|
||
Aha, the automatic reverting change in phab (done as part of the first backout) https://phabricator.services.mozilla.com/D199338?vs=814699&id=815391#toc zeroed the zip file in the patch. So when I landed it again, the zip file landed as zero sized.
Assignee | ||
Updated•7 months ago
|
Comment 19•7 months ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/149be3af5321 Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/aedd902e23a7 Make URLSearchParams not structured-cloneable, r=asuth,webidl
Comment 20•7 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/149be3af5321
https://hg.mozilla.org/mozilla-central/rev/aedd902e23a7
Description
•