1636761 - Make URLSearchParams not structured-cloneable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrea Marchesini [:baku]]

See https://github.com/whatwg/url/issues/370

Comment 1

[Anne (:annevk)]

Thanks! And URL too.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1636761 - Make URLSearchParams not structured-cloneable, r?smaug

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1636761 - URLSearchParams serialized for XHR in workers, r?smaug

Comment 4

[Anne (:annevk)]

We decided to wait with fixing this until post Covid-19 as there are some weird interactions with IDB (retrieving data would throw). And while probably nobody runs into that in practice, it's not worth the additional hassle at this point for the person that might.

Comment 5

[Phabricator Automation]

Comment on attachment 9147359 [details]
Bug 1636761 - URLSearchParams serialized for XHR in workers, r?smaug

Revision D74712 was moved to bug 1637857. Setting attachment 9147359 [details] to obsolete.

Comment 6

[Simon Pieters [:zcorpan]]

I found this bug because of this comment: https://github.com/mdn/content/issues/21178#issuecomment-1264062972

Is it time to pick this back up?

Comment 7

[Anne (:annevk)]

I created https://github.com/web-platform-tests/wpt/pull/37994 to test that this isn't supported.

Comment 8

[Thomas Wisniewski [:twisniewski]]

WebKit and Blink now both pass this test as of WebKit preview 170.

Comment 9

[edgul]

Attachment: Bug 1636761 - Make URLSearchParams not structured-cloneable, r?smaug,asuth

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Hi Jens,

It seems the main issues with the patch landing are related to the indexeddb use.
Could the LWS team take this bug as part of the interop 2024 effort for indexeddb?

Comment 11

[Jens Stutte [:jstutte]]

Jan is going to take a look.

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1636761 - Deserialize URLSearchParams manually; r=#dom-storage

URLSearchParams already stored in IndexedDB can't be easily removed. So instead
of doing potentially massive database upgrade, URLSearchParams objects are
deserialized as empty objects from now on.

Depends on D199344

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a34c69baa2f
Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/e19167a91657
Make URLSearchParams not structured-cloneable, r=asuth,webidl

Comment 14

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_structuredCloneAndExposed.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/whatwg/test_structuredCloneAndExposed.html | Test timed out. -

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcc9567f3950
Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth

Comment 16

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_URLSearchParams.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell.toml:dom/indexedDB/test/unit/test_URLSearchParams.js | xpcshell return code: 0

Comment 17

[Jan Varga [:janv]]

For some unknown reason the new test failed on autoland, but it works on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=65a83ad4219f59c3c9cb256f85f022b65c125fed

Comment 18

[Jan Varga [:janv]]

Aha, the automatic reverting change in phab (done as part of the first backout) https://phabricator.services.mozilla.com/D199338?vs=814699&id=815391#toc zeroed the zip file in the patch. So when I landed it again, the zip file landed as zero sized.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149be3af5321
Deserialize URLSearchParams manually; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/aedd902e23a7
Make URLSearchParams not structured-cloneable, r=asuth,webidl

Comment 20

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/149be3af5321
https://hg.mozilla.org/mozilla-central/rev/aedd902e23a7