1875781 - Add explicit (non-generated) URLSearchParams deserialization

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P1)

Description

[Jan Varga [:janv]]

Bug 1636761 needs to make URLSearchParams not structured-cloneable. Ideally, we would be able to adjust all structured clones containing URLSearchParams stored in IndexedDB to not contain URLSearchParams. The main concern is the amount of data which would need to be read, deserialized, serialized and stored again. It will be better to just create an empty object during deserialization for given tag. However, the support for serialization/deserialization of URLSearchParams is currently automatically generated and that code will disappear after bug 1636761. So we need to add support for explicit (non-generated) URLSearchParams deserialization in IndexedDB first.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1875781 - Add testing for pre-existing databases containing URLSearchParams; r=#dom-storage

Bug 1636761 needs to make URLSearchParams not structured-cloneable. This new
test makes sure that a serialized URLSearchParams object stored in a
pre-existing database is correctly deserialized when read from the pre-existing
database. The test is supposed to be modified as part of making URLSearchParams
not structured-cloneable.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1875781 - Add explicit non-default URLSearchParams deserialization; r=#dom-storage

This is a preparation for bug 1636761 which needs to make URLSearchParams not structured-cloneable.

Depends on D199338

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/464fd132979b
Add testing for pre-existing databases containing URLSearchParams; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/ad0e7eb94dfc
Add explicit non-default URLSearchParams deserialization; r=dom-storage-reviewers,asuth

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_structuredCloneAndExposed.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/whatwg/test_structuredCloneAndExposed.html | Test timed out. -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/407b25cb78f3
Add testing for pre-existing databases containing URLSearchParams; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/fa2f2d4895b1
Add explicit non-default URLSearchParams deserialization; r=dom-storage-reviewers,asuth

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_URLSearchParams.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell.toml:dom/indexedDB/test/unit/test_URLSearchParams.js | xpcshell return code: 0

Comment 7

[Jan Varga [:janv]]

For some unknown reason the new test failed on autoland, but it works on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=65a83ad4219f59c3c9cb256f85f022b65c125fed

Comment 8

[Jan Varga [:janv]]

Aha, the automatic reverting change in phab (done as part of the first backout) https://phabricator.services.mozilla.com/D199338?vs=814699&id=815391#toc zeroed the zip file in the patch. So when I landed it again, the zip file landed as zero sized.

Comment 9

[Serban Stanca [:SerbanS]]

Also, please take into account the fact that this hazard fail also appears.

• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | hazards | unrooted '<returnvalue>' of type 'JSObject*' live across GC call at dom/indexedDB/IndexedDatabase.cpp:396

Comment 10

[Jan Varga [:janv]]

Ok, thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b9ad25d33f8
Add testing for pre-existing databases containing URLSearchParams; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/82be6ce55d85
Add explicit non-default URLSearchParams deserialization; r=dom-storage-reviewers,asuth

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6b9ad25d33f8
https://hg.mozilla.org/mozilla-central/rev/82be6ce55d85