1636795 - Remove more virtual methods from ScriptStencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

We want to remove more of the finish* functions from ScriptStencil.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1636795 - Remove ScriptStencil::finishInnerFunctions. r?mgaudet

Instead, have a batch process at end of bytecode emission just before reading
out the result script. We do this for functions that are inner to a script we
are generating bytecode code. These functions may still be lazy but they are
potentially exposed in JSOp::Lambda/LambdaArray ops.

Depends on D74568

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1636795 - Remove ScriptStencil::finishGCThings. r?mgaudet

BytecodeEmitter and Smoosh use the same implementation so de-virtualize and
inline the implementation.

Depends on D74569

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1636795 - Add ScriptStencil::intoScript. r?mgaudet

This performs JSScript allocation by consuming the Stencil. For now we leave
handling of delazification compiles alone.

Depends on D74571

Comment 4

[Phabricator Automation]

Comment on attachment 9147136 [details]
Bug 1636795 - Add ScriptStencil::intoScript. r?mgaudet

Revision D74572 was moved to bug 1636796. Setting attachment 9147136 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1379162d0c
Remove ScriptStencil::finishInnerFunctions. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6f6db889e7d7
Remove ScriptStencil::finishGCThings. r=mgaudet

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8b1379162d0c
https://hg.mozilla.org/mozilla-central/rev/6f6db889e7d7