1636968 - reloading a view source tab will auto select the tab, if not focused

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[kernp25]

Attachment: mC1LlcVi0p.mp4

Right-clicking on a view source tab and choosing "Reload Tab" should not select the tab.

Comment 1

[kernp25]

Or is this the expected behavior?

Comment 2

[Dão Gottwald [:dao]]

This line is doing this: https://searchfox.org/mozilla-central/rev/fa52bedc4b401c12251513fa1c9df1753a29abb2/toolkit/actors/ViewSourcePageChild.jsm#170

Comment 3

[kernp25]

(In reply to Dão Gottwald [::dao] from comment #2)

This line is doing this: https://searchfox.org/mozilla-central/rev/fa52bedc4b401c12251513fa1c9df1753a29abb2/toolkit/actors/ViewSourcePageChild.jsm#170

But i don't think, it should select the tab, if not focused and when using the "Reload Tab" context menu item.

Comment 4

[Dão Gottwald [:dao]]

From what I can tell we can completely remove that line.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1636968 - Stop focusing the view-source content window on load. r=Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cce0d9704ab
Stop focusing the view-source content window on load. r=Honza

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5cce0d9704ab