1637039 - [rel=preload] Remove preloads from Document.Preloads() when used.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Honza Bambas (:mayhemer)]

To get into parity with Chrome's behavior. This doesn't apply to style loading because those use internal coalescing that ensures only one load for the same URL+attributes load. This also includes <link preload style> tags.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Adjust `PreloaderBase::NotifyStart` to read channel tainting also for non-opened preloads, r=edgar

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Notify image preload when its loading channel synchronously fails to open, remove a used image preload from Document, r=edgar

Depends on D76362

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Notify script preload when the loading channel synchronously fails to open, remove a used script preload from Document, r=hsivonen

Depends on D76363

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Notify style preload when the loading channel synchronously fails to open, r=emilio

Depends on D76364

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Use `RemoveSelf` when removing preload for a font on its use (cosmetic, no functional change), r=heycam

Depends on D76365

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637039 - Make synchronous open errors of a fetch preloading channel be notified to link preload tags, r=kershaw

Depends on D76366

Comment 7

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f695cebe3a85d47d8c0f778d0e6af63958a01622

Comment 8

[Honza Bambas (:mayhemer)]

Looks like the CSS notification patch produces a problem that I really don't understand (like an assertion failure, but not sure where exactly it's triggered:)
https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=682858%2C682846%2C682608%2C682564%2C689301%2C689322%2C700450&revision=a8f0514e5618471eb04892c67c2e687ff067258a

Narrowed down by this bi/section

Comment 9

[Honza Bambas (:mayhemer)]

(Ignore previous comment, belongs to a different bug)

Comment 10

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f695cebe3a85d47d8c0f778d0e6af63958a01622

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/059e7a42f158
Adjust `PreloaderBase::NotifyStart` to read channel tainting also for non-opened preloads, r=edgar
https://hg.mozilla.org/integration/autoland/rev/bfe7e80e784a
Notify image preload when its loading channel synchronously fails to open, remove a used image preload from Document, r=edgar
https://hg.mozilla.org/integration/autoland/rev/7dbee3b22e37
Notify script preload when the loading channel synchronously fails to open, remove a used script preload from Document, r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a9a776b65441
Notify style preload when the loading channel synchronously fails to open, r=emilio
https://hg.mozilla.org/integration/autoland/rev/e432e4f95af4
Use `RemoveSelf` when removing preload for a font on its use (cosmetic, no functional change), r=emilio
https://hg.mozilla.org/integration/autoland/rev/84ba9076a405
Make synchronous open errors of a fetch preloading channel be notified to link preload tags, r=kershaw

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/059e7a42f158
https://hg.mozilla.org/mozilla-central/rev/bfe7e80e784a
https://hg.mozilla.org/mozilla-central/rev/7dbee3b22e37
https://hg.mozilla.org/mozilla-central/rev/a9a776b65441
https://hg.mozilla.org/mozilla-central/rev/e432e4f95af4
https://hg.mozilla.org/mozilla-central/rev/84ba9076a405