1637043 - Stop highlighting the heuristic search result

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Harry Twyford]

Currently, we highlight the heuristic and "Search in Private Window" results. This makes less sense since we switched suggestions to highlight the suggested part instead of the typed part. This is newly relevant since we're introducing tail suggestions, which depend on the pleasing visual effect of the typed string, heuristic result, and tail suggestion all lining up.

We should stop highlighting the heuristic result.

Comment 1

[Marco Bonardo [:mak]]

I assume this is only for search results, in case of autofill for example we should still highlight the typed part.
So if a result is a search and it's heuristic or search in private window, we should no highlight. Or maybe in general if it's a search we should never highlight the typed part.

Comment 2

[Harry Twyford]

Yes, I should've clarified that. Thanks.

What are the other cases where we highlight the typed part, other than the heuristic search result and the Search in Private Window result? I was just thinking of setting the query payload field to UrlbarUtils.HIGHLIGHT.NONE in UrlbarProviderUnifiedComplete, UrlbarProviderSearchSuggestions, and UrlbarProviderPrivateSearch.

Comment 3

[Marco Bonardo [:mak]]

I was mostly thinking to a catch-all where for search results sets highlight to SUGGESTED instead of typed, so that new search results would automatically get the right behavior. But I'm not sure where we could do that, likely we should just do what you said!

Comment 4

[Harry Twyford]

Attachment: urlbar-text-misalignment.png

I'm also going to tweak urlbar font sizes in this patch since we use slightly different sizes in #urlbar vs in .urlbarView. This is more obvious when the heuristic result isn't bold, as seen in this screenshot.

Comment 5

[Harry Twyford]

Attachment: Bug 1637043 - Stop highlighting the heuristic search result. r?dao

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset de6d1c1375ee (bug 1637043) for browser_autocomplete_a11y_label.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=O5DLxQvcS0W92ndU6cJVHw-0&fromchange=3dfc4d905e23be7412a11024cc5788690ac0e1c1&searchStr=mochitest-browser-chrome&tochange=40835aba2708c6f2e3c14428945fa64857899a16

Backout link: https://hg.mozilla.org/integration/autoland/rev/40835aba2708c6f2e3c14428945fa64857899a16

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301830671&repo=autoland&lineNumber=5634

[task 2020-05-12T01:33:34.833Z] 01:33:34     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js
[task 2020-05-12T01:33:34.846Z] 01:33:34     INFO - GECKO(1795) | [Parent 1795: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x12c7a0c00 == 6 [pid = 1795] [id = {ef72930b-11b5-524d-b8b4-5eceebe3b670}]
[task 2020-05-12T01:33:34.847Z] 01:33:34     INFO - GECKO(1795) | [Parent 1795: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (0x131c7f7d0) [pid = 1795] [serial = 58] [outer = 0x0]
[task 2020-05-12T01:33:34.847Z] 01:33:34     INFO - GECKO(1795) | [Parent 1795: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 12 (0x12c7e7000) [pid = 1795] [serial = 59] [outer = 0x131c7f7d0]
[task 2020-05-12T01:33:34.918Z] 01:33:34     INFO - GECKO(1795) | [Parent 1795, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4285
[task 2020-05-12T01:33:34.923Z] 01:33:34     INFO - GECKO(1795) | [Parent 1795: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (0x130248000) [pid = 1795] [serial = 60] [outer = 0x131c7f7d0]
[task 2020-05-12T01:33:35.339Z] 01:33:35     INFO - GECKO(1795) | [Parent 1795, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-05-12T01:33:35.340Z] 01:33:35     INFO - GECKO(1795) | [Parent 1795, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-05-12T01:33:35.424Z] 01:33:35     INFO - GECKO(1795) | [Parent 1795, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp, line 1556
[task 2020-05-12T01:33:35.881Z] 01:33:35     INFO - TEST-INFO | started process screencapture
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - TEST-INFO | screencapture: exit 0
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - Buffered messages logged at 01:33:34
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - Entering test bound switchToTab
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - Buffered messages logged at 01:33:35
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should have a switch tab result - 1 == 1 - 
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Result a11y label should be: <title>— Switch to Tab - 
[task 2020-05-12T01:33:36.014Z] 01:33:36     INFO - Leaving test bound switchToTab
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - Entering test bound searchSuggestions
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should get at least heuristic result + two search suggestions - 4 >= 3 - 
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should still have expected searches remaining - 3 >= 0 - 
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - Buffered messages finished
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Check result label - "foo — Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" == "foo— Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js :: searchSuggestions :: line 141
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - Stack trace:
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js:searchSuggestions:141
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-12T01:33:36.015Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should still have expected searches remaining - 2 >= 0 - 
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Check result label - "foo — Search in a Private Window" == "foo— Search in a Private Window" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js :: searchSuggestions :: line 134
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - Stack trace:
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js:searchSuggestions:134
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-12T01:33:36.016Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should still have expected searches remaining - 2 >= 0 - 
[task 2020-05-12T01:33:36.140Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Check result label - "foofoo — Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" == "foofoo — Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" - 
[task 2020-05-12T01:33:36.140Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Should still have expected searches remaining - 1 >= 0 - 
[task 2020-05-12T01:33:36.356Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | Check result label - "foo bar— Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" == "foo bar— Search with browser_searchSuggestionEngine searchSuggestionEngine.xml" - 
[task 2020-05-12T01:33:36.356Z] 01:33:36     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | true == true - 
[task 2020-05-12T01:33:36.356Z] 01:33:36     INFO - Leaving test bound searchSuggestions
[task 2020-05-12T01:33:36.376Z] 01:33:36     INFO - GECKO(1795) | [Parent 1795, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp, line 1556
[task 2020-05-12T01:33:36.406Z] 01:33:36     INFO - GECKO(1795) | MEMORY STAT | vsize 7872MB | residentFast 534MB | heapAllocated 161MB
[task 2020-05-12T01:33:36.407Z] 01:33:36     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js | took 1571ms

Comment 7

[Harry Twyford]

The changes in this patch made an additional part of browser_autocomplete_a11y_label susceptible to bug 1550644 so the test needed a small tweak. New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d2c5c63fa9e9c6a07e20eb4863f4c2d51468947

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b755a09c18c
Stop highlighting the heuristic search result. r=dao

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7b755a09c18c

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 78.0a1 (2020-05-11), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 78.0a1(2020-05-20), on Windows 10 x64 and macOS 10.13.6.