Closed Bug 1637140 Opened 4 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-FAIL | firefox/libxul.so differs. See the diff.html or diff.txt artifact

Categories

(Firefox Build System :: General, defect, P5)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox76 unaffected, firefox77 unaffected, firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: glandium)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1637140 - Upgrade hashbrown to 0.7.2.
47 bytes, text/x-phabricator-request
Details | Review

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=301817312&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LYISc5olQ2e2zrF9s7iwIA/runs/0/artifacts/public/logs/live_backing.log

[task 2020-05-11T23:38:24.195Z] + diffoscope --html diff.html --text diff.txt --progress --output-empty --no-default-limits --max-page-size 100000000 --max-page-diff-block-lines 10000 --exclude-directory-metadata --exclude-command .--line-numbers a b
[task 2020-05-11T23:38:24.268Z] | | 0% ETA: --:--:--
[task 2020-05-11T23:38:24.268Z] 2020-05-11 23:38:24 W: diffoscope.main: Fuzzy-matching is currently disabled as the "tlsh" module is unavailable.
[task 2020-05-11T23:38:24.318Z] | | 0% ETA: --:--:--
[task 2020-05-11T23:38:24.318Z] | | 0% application.ini ETA: 0:33:06
[task 2020-05-11T23:38:24.336Z] | | 0% browser ETA: 0:28:03
[task 2020-05-11T23:38:24.336Z] | | 0% default16.png ETA: 310 days, 6:25:25
[task 2020-05-11T23:38:24.336Z] | | 0% default32.png ETA: 304 days, 9:06:06
[task 2020-05-11T23:38:24.336Z] | | 0% default48.png ETA: 289 days, 7:34:43
[task 2020-05-11T23:38:24.336Z] | | 0% default64.png ETA: 264 days, 5:19:07
[task 2020-05-11T23:38:24.336Z] | | 0% ETA: 236 days, 16:22:14
[task 2020-05-11T23:38:24.336Z] | | 0% ETA: 236 days, 22:43:15
[task 2020-05-11T23:38:24.336Z] | | 0% ETA: 167 days, 13:24:55
[task 2020-05-11T23:38:24.336Z] | | 0% …ashreporter-override.ini ETA: 137 days, 1:35:05
[task 2020-05-11T23:38:24.340Z] | | 0% features ETA: 120 days, 23:57:34
[task 2020-05-11T23:38:24.342Z] | | 0% …autofill@mozilla.org.xpi ETA: 2048 days, 23:03:23
[task 2020-05-11T23:38:24.343Z] | | 0% …eenshots@mozilla.org.xpi ETA: 245 days, 15:39:44
[task 2020-05-11T23:38:24.344Z] | | 0% …reporter@mozilla.org.xpi ETA: 171 days, 0:02:17
[task 2020-05-11T23:38:24.345Z] | | 0% webcompat@mozilla.org.xpi ETA: 166 days, 22:52:28
[task 2020-05-11T23:38:24.345Z] | | 0% ETA: 154 days, 15:57:08
[task 2020-05-11T23:38:24.373Z] | | 0% omni.ja ETA: 154 days, 22:51:38
[task 2020-05-11T23:38:24.373Z] | | 0% ETA: 0:58:26
[task 2020-05-11T23:38:24.375Z] | | 0% crashreporter ETA: 0:58:33
[task 2020-05-11T23:38:24.375Z] | | 0% crashreporter.ini ETA: 0:01:15
[task 2020-05-11T23:38:24.381Z] | | 0% defaults ETA: 0:01:14
[task 2020-05-11T23:38:24.381Z] | | 0% ETA: 0:01:17
[task 2020-05-11T23:38:24.381Z] | | 0% ETA: 0:01:17
[task 2020-05-11T23:38:24.381Z] | | 0% dependentlibs.list ETA: 0:01:17
[task 2020-05-11T23:38:24.381Z] | | 0% dmd.py ETA: 0:01:17
[task 2020-05-11T23:38:24.382Z] | | 0% firefox ETA: 0:01:09
[task 2020-05-11T23:38:24.384Z] | | 0% firefox-bin ETA: 0:01:06
[task 2020-05-11T23:38:24.384Z] | | 0% fix_stacks.py ETA: 0:00:19
[task 2020-05-11T23:38:24.389Z] | | 0% fonts ETA: 0:00:19
[task 2020-05-11T23:38:24.389Z] | | 0% ETA: 0:00:20
[task 2020-05-11T23:38:24.396Z] | | 0% gmp-clearkey ETA: 0:00:20
[task 2020-05-11T23:38:24.397Z] | | 0% manifest.json ETA: 0:00:21
[task 2020-05-11T23:38:24.397Z] | | 0% ETA: 0:00:21
[task 2020-05-11T23:38:24.397Z] | | 0% ETA: 0:00:21
[task 2020-05-11T23:38:24.399Z] | | 0% gtk2 ETA: 0:00:21
[task 2020-05-11T23:38:24.399Z] | | 0% ETA: 0:00:22
[task 2020-05-11T23:38:24.402Z] | | 0% icons ETA: 0:00:22
[task 2020-05-11T23:38:24.402Z] | | 0% ETA: 0:00:22
[task 2020-05-11T23:38:24.404Z] | | 0% libfreeblpriv3.so ETA: 0:00:22
[task 2020-05-11T23:38:24.404Z] | | 0% liblgpllibs.so ETA: 0:00:15
[task 2020-05-11T23:38:24.406Z] | | 0% libmozavcodec.so ETA: 0:00:15
[task 2020-05-11T23:38:24.408Z] | | 1% libmozavutil.so ETA: 0:00:13
[task 2020-05-11T23:38:24.408Z] | | 1% libmozgtk.so ETA: 0:00:12
[task 2020-05-11T23:38:24.410Z] | | 1% libmozsandbox.so ETA: 0:00:12
[task 2020-05-11T23:38:24.412Z] | | 1% libmozsqlite3.so ETA: 0:00:11
[task 2020-05-11T23:38:24.412Z] | | 1% libmozwayland.so ETA: 0:00:07
[task 2020-05-11T23:38:24.414Z] | | 1% libnspr4.so ETA: 0:00:07
[task 2020-05-11T23:38:24.416Z] | | 2% libnss3.so ETA: 0:00:07
[task 2020-05-11T23:38:24.417Z] | | 2% libnssckbi.so ETA: 0:00:06
[task 2020-05-11T23:38:24.419Z] | | 2% libnssutil3.so ETA: 0:00:05
[task 2020-05-11T23:38:24.419Z] | | 2% libplc4.so ETA: 0:00:05
[task 2020-05-11T23:38:24.419Z] | | 2% libplds4.so ETA: 0:00:05
[task 2020-05-11T23:38:24.421Z] | | 2% libsmime3.so ETA: 0:00:05
[task 2020-05-11T23:38:24.422Z] | | 2% libsoftokn3.so ETA: 0:00:05
[task 2020-05-11T23:38:24.424Z] | | 3% libssl3.so ETA: 0:00:04
[task 2020-05-11T23:38:59.745Z] | | 3% libxul.so ETA: 0:00:04
[task 2020-05-11T23:38:59.772Z] |# | 6% …ox/libxul.so [.gnu.hash] ETA: 0:08:16
[task 2020-05-11T23:38:59.894Z] |## | 9% …efox/libxul.so [.dynstr] ETA: 0:05:37
[task 2020-05-11T23:39:00.541Z] |### | 12% …ul.so [.elfhack.data.v0] ETA: 0:04:12
[task 2020-05-11T23:39:00.803Z] |#### | 15% …ul.so [.elfhack.text.v0] ETA: 0:03:22
[task 2020-05-11T23:39:01.066Z] |#### | 18% …irefox/libxul.so [.init] ETA: 0:02:45
[task 2020-05-11T23:39:01.550Z] |##### | 20% …firefox/libxul.so [.plt] ETA: 0:02:19
[task 2020-05-11T23:39:01.833Z] |###### | 23% …fox/libxul.so [.plt.got] ETA: 0:01:59
[task 2020-05-11T23:46:24.352Z] |####### | 26% …irefox/libxul.so [.text] ETA: 0:01:43
[task 2020-05-11T23:46:24.715Z] |####### | 29% …fox/libxul.so [text_env] ETA: 0:19:08
[task 2020-05-11T23:46:24.992Z] |######## | 32% …irefox/libxul.so [.fini] ETA: 0:16:45
[task 2020-05-11T23:46:42.176Z] |######### | 35% …efox/libxul.so [.rodata] ETA: 0:14:45
[task 2020-05-11T23:46:43.836Z] |########## | 38% …ibxul.so [.eh_frame_hdr] ETA: 0:13:31
[task 2020-05-11T23:46:52.474Z] |########### | 40% …ox/libxul.so [.eh_frame] ETA: 0:12:02
[task 2020-05-11T23:46:52.500Z] |########### | 43% …l.so [.gcc_except_table] ETA: 0:10:53
[task 2020-05-11T23:46:52.520Z] |############ | 46% …refox/libxul.so [.tdata] ETA: 0:09:42
[task 2020-05-11T23:46:52.541Z] |############# | 49% …irefox/libxul.so [.tbss] ETA: 0:08:39
[task 2020-05-11T23:46:52.561Z] |############## | 52% …/libxul.so [.init_array] ETA: 0:07:43
[task 2020-05-11T23:46:52.583Z] |############## | 55% …/libxul.so [.fini_array] ETA: 0:06:53
[task 2020-05-11T23:46:54.510Z] |############### | 57% …libxul.so [.data.rel.ro] ETA: 0:06:08
[task 2020-05-11T23:46:54.531Z] |################ | 60% …firefox/libxul.so [.got] ETA: 0:05:28
[task 2020-05-11T23:46:54.562Z] |################# | 63% …fox/libxul.so [.got.plt] ETA: 0:04:50
[task 2020-05-11T23:46:54.683Z] |################# | 66% …irefox/libxul.so [.data] ETA: 0:04:16
[task 2020-05-11T23:46:54.703Z] |################## | 69% …firefox/libxul.so [.bss] ETA: 0:03:45
[task 2020-05-11T23:46:54.721Z] |################### | 72% …fox/libxul.so [.comment] ETA: 0:03:16
[task 2020-05-11T23:46:54.740Z] |#################### | 75% ….__warn_memset_zero_len] ETA: 0:02:49
[task 2020-05-11T23:46:54.759Z] |##################### | 77% …bxul.so [.gnu_debuglink] ETA: 0:02:24
[task 2020-05-11T23:47:15.711Z] |##################### | 80% …efox/libxul.so [.strtab] ETA: 0:02:01
[task 2020-05-11T23:47:15.731Z] |###################### | 83% …ox/libxul.so [.shstrtab] ETA: 0:01:43
[task 2020-05-11T23:47:15.731Z] |####################### | 86% ETA: 0:01:22
[task 2020-05-11T23:47:15.736Z] |####################### | 86% minidump-analyzer ETA: 0:01:22
[task 2020-05-11T23:47:15.752Z] |####################### | 87% omni.ja ETA: 0:01:17
[task 2020-05-11T23:47:15.756Z] |########################## | 99% pingsender ETA: 0:00:04
[task 2020-05-11T23:47:15.756Z] |########################## | 99% platform.ini ETA: 0:00:02
[task 2020-05-11T23:47:15.760Z] |########################## | 99% plugin-container ETA: 0:00:02
[task 2020-05-11T23:47:15.760Z] |########################## | 99% precomplete ETA: 0:00:00
[task 2020-05-11T23:47:15.760Z] |########################## | 99% removed-files ETA: 0:00:00
[task 2020-05-11T23:47:15.761Z] |########################## | 99% update-settings.ini ETA: 0:00:00
[task 2020-05-11T23:47:15.764Z] |########################## | 99% updater ETA: 0:00:00
[task 2020-05-11T23:47:15.764Z] |########################## | 99% updater.ini ETA: 0:00:00
[task 2020-05-11T23:47:15.764Z] |###########################| 100% ETA: 0:00:00
[task 2020-05-11T23:47:15.764Z] |###########################| 100% ETA: 0:00:00
[task 2020-05-11T23:47:15.764Z] |###########################| 100% ETA: 0:00:00
[task 2020-05-11T23:49:54.634Z] |###########################| 100% Time: 0:08:51
[task 2020-05-11T23:49:54.634Z] + report_error diff
[task 2020-05-11T23:49:54.634Z] + python3
[task 2020-05-11T23:49:55.064Z] TEST-UNEXPECTED-FAIL | firefox/libxul.so differs. See the diff.html or diff.txt artifact
[task 2020-05-11T23:49:55.066Z] + fail
[task 2020-05-11T23:49:55.066Z] + exit 1
[taskcluster 2020-05-11 23:49:55.381Z] === Task Finished ===

Assignee: nobody → mh+mozilla
Flags: needinfo?(rstewart)
Regressed by: 1634204

Turns out this wasn't bug 1634204, but bug 1624056, which is not obvious at all why, but a backout on top of m-c does fix it.

Regressed by: 1624056
No longer regressed by: 1634204
Has Regression Range: --- → yes
Keywords: regression

Set release status flags based on info from the regressing bug 1624056

status-firefox76: --- → unaffected
status-firefox77: --- → unaffected
status-firefox78: --- → affected

So, it turns out ahash has a feature that enables the use of a random seed generated at compile time. That feature is enabled by default, but hashbrown, which is what brings ahash in, disables its default features. But it also provides a feature to enable it, and enables that feature by default. So all the 4 crates we have in tree that pull hashbrown as a dependency (there are actually more with cranelift, but those dependencies are not enabled by default), end up enabling that compile-time random seed.

You might ask, why only now? It turns out the compile-time random seed was eliminated as dead code before bug 1624056, and that's not the case anymore, but we don't actually /need/ that.

Attachment #9147879 - Attachment description: Bug 1637140 - Disable the ahash-compile-time-rng feature of hashbrown that makes builds unreproducible. → Bug 1637140 - Upgrade hashbrown to 0.7.2.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/571152088848
Upgrade hashbrown to 0.7.2. r=emilio

https://hg.mozilla.org/mozilla-central/rev/571152088848

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: