Closed Bug 1637261 Opened 5 years ago Closed 5 years ago

mach try fails on windows 10 (TypeError: a bytes-like object is required, not 'str')

Categories

(Developer Infrastructure :: Try, defect)

x86_64
Windows 10
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1637305

People

(Reporter: geekboy, Unassigned)

References

(Blocks 1 open bug)

Details

After the upgrade to python 3 for mach try (bug 1632429), I can't run mach try chooser with mozbuild. mach try empty fails with the same stack.

I'm on mozilla-central rev 1706d4d54ec68fae1280305b70a02cb24c16ff68

The details of the failure are as follows:

TypeError: a bytes-like object is required, not 'str'

  File "c:\mozilla-source\mozilla-central\tools/tryselect/mach_commands.py", line 327, in try_chooser
    return self.run(**kwargs)
  File "c:\mozilla-source\mozilla-central\tools/tryselect/mach_commands.py", line 178, in run
    return mod.run(**kwargs)
  File "c:\mozilla-source\mozilla-central\tools\tryselect\selectors\chooser\__init__.py", line 42, in run
    check_working_directory(push)
  File "c:\mozilla-source\mozilla-central\tools\tryselect\push.py", line 83, in check_working_directory
    if not vcs.working_directory_clean():
  File "c:\mozilla-source\mozilla-central\python/mozversioncontrol\mozversioncontrol\__init__.py", line 412, in working_directory_clean
    return not len(self._run(*args).strip())
  File "c:\mozilla-source\mozilla-central\python/mozversioncontrol\mozversioncontrol\__init__.py", line 318, in _run
    return super(HgRepository, self)._run(*args, **runargs)
  File "c:\mozilla-source\mozilla-central\python/mozversioncontrol\mozversioncontrol\__init__.py", line 115, in _run
    universal_newlines=True)
  File "c:\mozilla-build\python3\lib\subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "c:\mozilla-build\python3\lib\subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "c:\mozilla-build\python3\lib\subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "c:\mozilla-build\python3\lib\subprocess.py", line 1119, in _execute_child
    args = list2cmdline(args)
  File "c:\mozilla-build\python3\lib\subprocess.py", line 530, in list2cmdline
    needquote = (" " in arg) or ("\t" in arg) or not arg
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.