1637336 - Change WebRTC screen / window sharing permission dialog to use the same Not Now | Allow popup notification type as Persistent Storage

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Currently, the WebRTC screen / window sharing popup notification includes a checkbox at the bottom to "Remember this decision", but when checked, we display a warning to users that... we can't actually remember the decision for sharing the screen.

This is true - we never want to remember the decision for sharing the screen, or audio from screens / windows. It seems weird, then, to offer users this checkbox since it's "an impossible option".

shorlander suggested using a Popup Notification style similar to the persistent storage permission. See attachment.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Persistent storage permission dialog

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1637336 - Add a preference that uses an alternative WebRTC screen sharing permission panel configuration. r?johannh!

This is the same preference that will power the notification suppression
option in bug 1635257, hence the preference name.

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1635257, Bug 1637336) fr causing failures in browser_all_files_referenced.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=732ef8965a6ef1064a469d2fabc83a7a88396dfa&selectedTaskRun=FO8bZn4kTwe-unPi5RF6Yw-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302519422&repo=autoland&lineNumber=1818

Backout: https://hg.mozilla.org/integration/autoland/rev/8311cd4648efdbf5d585d15f5219272509928526

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/6b163af655a6000b692ac1e677440977802763e6
https://hg.mozilla.org/mozilla-central/rev/6b163af655a6

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9147754 [details]
Bug 1637336 - Add a preference that uses an alternative WebRTC screen sharing permission panel configuration. r?johannh!

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a branch to our WebRTC UI code that is preffed off by default.
• String changes made/needed: None

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Note that when uplifting, there might be a merge conflict with browser/base/content/test/static/browser_all_files_referenced.js. This is a simple manual conflict resolution, where we need to account for these lines existing in beta:

 // services/sync/modules/bridged_engine.js
 { file: "resource://services-sync/bridged_engine.js" },

These were removed in Nightly recently by bug 1628752.

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9147754 [details]
Bug 1637336 - Add a preference that uses an alternative WebRTC screen sharing permission panel configuration. r?johannh!

Planned uplift approved via the release exception process, uplift approved for beta 8, thanks.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e0600c26817