1635257 - Allow users to suppress notifications from Firefox when sharing their screen

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Ideally, we'd be able to exclude notifications amongst the things that are shared when sharing the entire screen over WebRTC. Unfortunately, doing so is non-trivial.

In the short-term, we'd like to expose the ability for the user to suppress notifications from the browser when sharing the screen.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1635257 - Extend the nsIAlertsDoNotDisturb interface with an attribute for suppressing notifications when screen sharing. r?MattN!

Depends on D73734

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1635257 - Implement some of nsIAlertsDoNotDisturb for the macOS NotificationCenter backend. r?mstange!

This doesn't implement manualDoNotDisturb, since we don't want to show the
about:preferences option for suppressing notifications on macOS.

Depends on D74242

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1635257 - Add a checkbox to allow users to suppress notifications from the browser when sharing the screen. r?johannh!

Depends on D74243

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1635257, Bug 1637336) fr causing failures in browser_all_files_referenced.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=732ef8965a6ef1064a469d2fabc83a7a88396dfa&selectedTaskRun=FO8bZn4kTwe-unPi5RF6Yw-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302519422&repo=autoland&lineNumber=1818

Backout: https://hg.mozilla.org/integration/autoland/rev/8311cd4648efdbf5d585d15f5219272509928526

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/3a7bd505695e4faf0b6e979f2bfe47daccf30fe5
https://hg.mozilla.org/integration/autoland/rev/17a62bbe263cd55a76068e7c0583d3a182d5571e
https://hg.mozilla.org/integration/autoland/rev/9f1412f412e203eb6290a52b7db1155e858d75b9
https://hg.mozilla.org/mozilla-central/rev/3a7bd505695e
https://hg.mozilla.org/mozilla-central/rev/17a62bbe263c
https://hg.mozilla.org/mozilla-central/rev/9f1412f412e2

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9146474 [details]
Bug 1635257 - Add a checkbox to allow users to suppress notifications from the browser when sharing the screen. r?johannh!

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1637336
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Builds upon bug 1637336 by changing the checkbox for the WebRTC permission dialog for screen sharing to control notification silencing. Also adds the platform support for notification silencing.

This is low-risk because all of these branches are preffed off by default.

• String changes made/needed: None.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9146474 [details]
Bug 1635257 - Add a checkbox to allow users to suppress notifications from the browser when sharing the screen. r?johannh!

Planned uplift approved via the release exception process, uplift approved for beta 8, thanks.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e66bb51409663b506083e172b83870d3d1ec3eb
https://hg.mozilla.org/releases/mozilla-beta/rev/57b45999b145adced082b05149144c55d0b90ac0
https://hg.mozilla.org/releases/mozilla-beta/rev/7cfdc9c5b7093370bac2a18a67fd2fe09fd54378