1637640 - Enable page load events for frames

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Comparison between page load events of Chrome and Firefox

Right now we disable any page load event for frames:

https://searchfox.org/mozilla-central/rev/0688ffdef223dac527c2fcdb25560118c4e4df51/remote/domains/content/Page.jsm#259-262

As result we emit view lesser events than Chrome, and this seems to cause various problems in Puppeteer because event handlers like for Page.frameNavigated rely on the correct frame id and parent frame id:

https://searchfox.org/mozilla-central/rev/0688ffdef223dac527c2fcdb25560118c4e4df51/remote/test/puppeteer/lib/FrameManager.js#233

Which means frames aren't correctly setup internally.

Given that the Page domain also makes use of the context observer, it has to be built upon the patches on bug 1593226.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1637640 - [remote] Enable page load events for frames.

Depends on D79451

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1637640 - [remote] Update Puppeteer expectation data.

Depends on D79452

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59cd08b79678
[remote] Enable page load events for frames. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/3fb7f441b1c1
[remote] Update Puppeteer expectation data. r=remote-protocol-reviewers,maja_zf

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/59cd08b79678
https://hg.mozilla.org/mozilla-central/rev/3fb7f441b1c1