Closed Bug 1641839 Opened 11 months ago Closed 11 months ago

Only emit Page.frameAttached and Page.frameAttached for frames

Categories

(Remote Protocol :: CDP, defect, P1)

defect

Tracking

(firefox77 unaffected, firefox78 wontfix, firefox79 fixed)

RESOLVED FIXED
Firefox 79
Tracking Status
firefox77 --- unaffected
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [puppeteer-beta-reserve])

Attachments

(1 file)

With the implementation of both the the Page.frameAttached and Page.frameDetached methods we now emit those events even for opened popup windows, and maybe new tabs/targets.

This causes some Puppeteer tests like this one to fail when the remote.frames.enabled preference has been turned enabled.

The fix will be easy. Just make sure that there is a parent browsing context for the docshell as observed via the webnavigation-create and webnavigation-destroy notifications.

Keywords: regression
Severity: -- → S3
Blocks: 1639467
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6fd4b85734e
[remote] Only emit Page.frameAttached and Page.frameAttached for frames. r=remote-protocol-reviewers,maja_zf
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Component: CDP: Page → CDP
You need to log in before you can comment on or make changes to this bug.