1637742 - IPCBlobInputStream should call the callback immediately upon receiving AsyncWait if stream is closed

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P2)

Description

[Subhamoy [:ssengupta][he/him]]

Currently multiple implementations of nsIAsyncInputStream return an error code (e.g., NS_BASE_STREAM_CLOSED) and do not call the callback if AsyncWait is called and the stream is already closed, which is not expected behaviour. These implementations should be updated to call the callback immediately in such a situation instead of returning an error.

Comment 1

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1637742 - P1 - Protocol documentation now states no error should be returned if AsyncWait is called on closed stream r=baku

Comment 2

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1637742 - P2 - IPCBlobInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Depends on D77407

Comment 3

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1637742 - P3 - PartiallySeekableInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Depends on D77408

Comment 4

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1641825 - nsBufferedInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Comment 5

[Phabricator Automation]

Comment on attachment 9152681 [details]
Bug 1641825 - nsBufferedInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Revision D77433 was moved to bug 1641825. Setting attachment 9152681 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9152622 [details]
Bug 1637742 - P3 - PartiallySeekableInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Revision D77409 was moved to bug 1641826. Setting attachment 9152622 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71080a3ec16c
P1 - Protocol documentation now states no error should be returned if AsyncWait is called on closed stream r=baku

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2015a4db7084
P2 - IPCBlobInputStream does not return error and executes callback on AsyncWait/AsyncLengthWait if stream is closed r=baku

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/71080a3ec16c
https://hg.mozilla.org/mozilla-central/rev/2015a4db7084