1637796 - WebRender does not handle mask render tasks that exceed the maximum task size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Connor Brewster [:cbrewster]]

Attachment: test-case.yaml

I ran into this while testing a patch for bug 1559861. This can happen if there is a very large clip that requires a mask render task which is applied to a picture that forms a raster root.

Mask render tasks are created in the following places:
https://searchfox.org/mozilla-central/rev/9f074fab9bf905fad62e7cc32faf121195f4ba46/gfx/wr/webrender/src/prim_store/mod.rs#4270
https://searchfox.org/mozilla-central/rev/9f074fab9bf905fad62e7cc32faf121195f4ba46/gfx/wr/webrender/src/prim_store/mod.rs#1057

We should downscale the masks so they fit within the maximum render task size. However, I am not sure if we can change the device pixel scale of the mask without it breaking other things.

Comment 1

[Connor Brewster [:cbrewster]]

Attachment: test-case.html

This is an additional HTML test-case which currently hits the max render task size assertion

Comment 2

[Connor Brewster [:cbrewster]]

Attachment: Bug 1637796: Scale down mask render tasks if they exceed the maximum size r=gw,Bert

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1637796 - Limit the size of mask render tasks to 4096x4096. r=gw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/115f94af4353
Scale down mask render tasks if they exceed the maximum size r=gw

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/115f94af4353