1637860 - about:logins broken in nightly on Linux (part 2)

Status: NEW

(Firefox :: about:logins, defect, P3)

Description

[Frederik Braun [:freddy]]

Going to about:logins leads to an error:

NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI] LoginBreaches.jsm:78

Interacting with the UI works only partially: Search works, but editing, showing passwords does not.

E.g., clicking "Edit" on the first entry:

Error: reauth is required to either be false or a non-empty string OSKeyStore.jsm:181:13
Uncaught AboutLoginsChild: error recording telemetry event: message.data.telemetryEvent is undefined AboutLoginsChild.jsm:217
AboutLoginsChild: error recording telemetry event: message.data.telemetryEvent is undefined AboutLoginsChild.jsm:217

Comment 1

[Matthew N. [:MattN]]

(In reply to Frederik Braun [:freddy] from comment #0)

Interacting with the UI works only partially: Search works, but editing, showing passwords does not.

E.g., clicking "Edit" on the first entry:

Error: reauth is required to either be false or a non-empty string OSKeyStore.jsm:181:13
Uncaught AboutLoginsChild: error recording telemetry event: message.data.telemetryEvent is undefined AboutLoginsChild.jsm:217
AboutLoginsChild: error recording telemetry event: message.data.telemetryEvent is undefined AboutLoginsChild.jsm:217

I think this should be fixed by bug 1636820. Does the problem happen with that fix?

Comment 2

[Frederik Braun [:freddy]]

I'm on on Linux Nightly built from https://hg.mozilla.org/mozilla-central/rev/d1114574b777bb00b85f73733a8bd6a78d2ad87e, which should include the aforementioned bug fix according to the hg shortlog.

Digging into my profile, the origins that throw the exception in LoginBreaches.jsm are old data from legacy extensions that didn't store proper web origins. I can see two types of origins stored:

from earlier versions of Firefox sync: chrome://sync
Likely from legacy FireFTP: bare hostnames like ftp.example.com
chrome URIs from other legacy extensions e.g., chrome://zotero

I suppose we could wrap the code that parses the origin into a try-catch. It's likely OK to skip those unparsable from breach checking.

Comment 3

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #1)

(In reply to Frederik Braun [:freddy] from comment #0)

Interacting with the UI works only partially: Search works, but editing, showing passwords does not.

E.g., clicking "Edit" on the first entry:

Error: reauth is required to either be false or a non-empty string OSKeyStore.jsm:181:13

I put a hacky fix in at https://hg.mozilla.org/integration/autoland/rev/bcca4b48fc21c84e61d8f4a18089e6faae704226 for now but this bug can resolve the issues in a better way.

This code is quite convoluted just to record telemetry that I'm not sure is actually useful. Can we reconsider going down this path for telemetry?

Comment 4

[Matthew N. [:MattN]]

We also need to test this code in automation.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Looks like we have a workaround/temporary fix but want to explore a better fix. Moving to backlog.