1637888 - Crash in [@ <name omitted> | mozilla::PreloaderBase::NotifyRestart]

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-d422b068-beca-4102-bcaa-40fa40200514.

Top 10 frames of crashing thread:

0 libxul.so <name omitted> xpcom/ds/PLDHashTable.cpp:492
1 libxul.so mozilla::PreloaderBase::NotifyRestart uriloader/preload/PreloaderBase.cpp:149
2 libxul.so mozilla::dom::ScriptLoader::RestartLoad dom/script/ScriptLoader.cpp:1254
3 libxul.so mozilla::dom::ScriptLoadHandler::OnStreamComplete dom/script/ScriptLoadHandler.cpp
4 libxul.so nsIncrementalStreamLoader::OnStopRequest netwerk/base/nsIncrementalStreamLoader.cpp:86
5 libxul.so nsCORSListenerProxy::OnStopRequest netwerk/protocol/http/nsCORSListenerProxy.cpp:605
6 libxul.so mozilla::net::HttpChannelChild::DoOnStopRequest netwerk/protocol/http/HttpChannelChild.cpp:1261
7 libxul.so mozilla::net::HttpChannelChild::OnStopRequest netwerk/protocol/http/HttpChannelChild.cpp:1125
8 libxul.so mozilla::net::ChannelEventQueue::FlushQueue netwerk/ipc/ChannelEventQueue.cpp:90
9 libxul.so mozilla::net::ChannelEventQueue::ResumeInternal netwerk/ipc/ChannelEventQueue.cpp:148

There is 1 crash in nightly 78 with buildid 20200513094918. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1618287.

[1] https://hg.mozilla.org/mozilla-central/rev?node=86c478d114ec

Comment 1

[Honza Bambas (:mayhemer)]

Yep, just a missing non-null check. On it.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1637888 - Add a null-check for Document passed to `PreloaderBase::NotifyRestart` as it is a valid case to happen, r=emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce86fc54910a
Add a null-check for Document passed to `PreloaderBase::NotifyRestart` as it is a valid case to happen, r=emilio

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ce86fc54910a