1638030 - Tab moving animation is broken

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1638030 - Fix broken gBrowser.animationsEnabled checks. r=jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65de1f6a9f6e
Fix broken gBrowser.animationsEnabled checks. r=Gijs

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/65de1f6a9f6e

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9149065 [details]
Bug 1638030 - Fix broken gBrowser.animationsEnabled checks. r=jaws

Beta/Release Uplift Approval Request

• User impact if declined: Animation is missing when dropping a tab in the tab strip
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Drag a tab within the tab strip and drop it somewhere but not exactly at the target location. The tab should slide over to its final location.
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed: -

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9149065 [details]
Bug 1638030 - Fix broken gBrowser.animationsEnabled checks. r=jaws

Low risk, uplift accepted for 77 beta 8, thanks.

Comment 6

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue in Beta 77.0b7 using Windows 10.
Verified - Fixed in latest Nightly 78.0a1 (build id: 20200517213618) using Windows 10 and Ubuntu 18.04. Changed the Nightly flag accordingly and waiting for Beta 8 uplift.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d89dbbcf87a8

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 77.0b8 (build id: 20200518141716) as well.