1638092 - Browsingcontext shouldn't be required to call external protocol service's loadURI (unbreak email link, download integration fallbacks, thunderbird)

Status: VERIFIED FIXED

(Firefox :: File Handling, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Click File and then click email link.

Actual results:

Email link doesn't open email, as it has done normally.

Expected results:

Email link click should open email with link attached.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Alt > File > Email Link... is broken

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6f09ab53ebc98a83d19a9e2b55fa9a3eeb20b091&tochange=0c7811dc2ea9493f195f554f7cbb68193f77f6e5

Comment 2

[Alice0775 White]

Error in Browser consolle:
Uncaught
Exception { name: "NS_ERROR_XPC_NOT_ENOUGH_ARGS", message: "Not enough arguments [nsIExternalProtocolService.loadURI]", result: 2153185281, filename: "chrome://browser/content/browser.js", lineNumber: 7974, columnNumber: 0, data: null, stack: "_launchExternalUrl@chrome://browser/content/browser.js:7974:22\nsendMessage@chrome://browser/content/browser.js:7963:10\nsendLinkForBrowser@chrome://browser/content/browser.js:7946:10\noncommand@chrome://browser/content/browser.xhtml:1:17\n", location: XPCWrappedNative_NoHelper }
browser.js:7974

Comment 3

[:Gijs (he/him)]

Lovely, lots of stuff actually broke without any automated test coverage. :-\

Comment 4

[:Gijs (he/him)]

So I thought I looked for JS consumers when fixing bug 1196151 but I clearly didn't do a good job, because:

https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/toolkit/content/widgets/text.js#354
https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/toolkit/content/contentAreaUtils.js#1231
https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/toolkit/components/downloads/DownloadIntegration.jsm#807
https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/toolkit/components/downloads/DownloadIntegration.jsm#873
https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/browser/base/content/browser.js#7974

are all broken, and TB ran into issues here too.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1638092 - do not require a browsingcontext to call the external protocol service's loadURI method, r?mattwoodrow

Comment 7

[Calum Mackay]

slightly different error on MacOS (assuming this is the same issue; appeared in Daily 0514):

Uncaught
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIExternalProtocolService.loadURI]", result: 2147942487, filename: "chrome://communicator/content/contentAreaClick.js", lineNumber: 230, columnNumber: 0, data: null, stack: "openLinkExternally@chrome://communicator/content/contentAreaClick.js:230:6\ncontentAreaClick@chrome://communicator/content/contentAreaClick.js:200:21\nonclick@chrome://messenger/content/messenger.xhtml:1:8\n", location: XPCWrappedNative_NoHelper }
contentAreaClick.js:230
openLinkExternally chrome://communicator/content/contentAreaClick.js:230
contentAreaClick chrome://communicator/content/contentAreaClick.js:200
onclick chrome://messenger/content/messenger.xhtml:1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f84996f6ae6
do not require a browsingcontext to call the external protocol service's loadURI method, r=mattwoodrow

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2f84996f6ae6

Comment 10

[doug2]

External links working in 2020-05-18 Thanks.

Comment 11

[:Gijs (he/him)]

Marking verified per comment 10. Thanks!