1638803 - Add automated tests for the window parenting of the protocol handler choice dialog

Status: RESOLVED WONTFIX

(Firefox :: File Handling, task, P3)

Description

[:Gijs (he/him)]

This was likely broken in e10s for a while prior to the changes in bug 1638092, because we passed something on which we tried to call getInterface to obtain an nsIDOMWindow. But the callers:

https://searchfox.org/mozilla-beta/search?q=nsExternalHelperAppService%3A%3ALoadURI&path=&case=false&regexp=false

pass various different things, and AFAICT only the docshell case would reliably produce a same-process window - but we wouldn't be hitting the docshell case with e10s enabled. So I suspect we just always passed null as the window parent of the dialog prior to the changes in bug 1638092 and bug 1196151.

When we show the dialog in response to an unknown protocol loading from within web content, we should verify it's parented to the right chrome window.

Comment 1

[:Gijs (he/him)]

There is some test coverage here now; it's not really clear that the "right" parent window is going to make a difference (more than just showing the window topmost when it appears), and we're likely to move this to be a tab-modal dialog soon, at which point this becomes moot. So going to close this out.