1638223 - Clicking on the reader mode toolbar buttons closes and immediately reopens the menus

Status: VERIFIED WORKSFORME

(Toolkit :: Reader Mode, defect, P3)

Description

[Mathew Hodson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

1. Go to https://getpocket.com/explore/item/this-is-your-brain-on-architecture
2. Press F9 to toggle reader view
3. Click the text or voice control button in the reader mode toolbar
4. Click the button again

Actual results:

The menu flashes as it closes and reopens instantly.

Expected results:

The menu should close.

Comment 1

[Mathew Hodson]

I can also reproduce on Nightly 78.0a1 build ID 20200513094918

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[:Gijs (he/him)]

The root cause here was a mousedown listener that closes all open popups, and a click listener that opens them. So if you clicked the anchor, as soon as you mousedown, the popup closed, and when the mouseup and click event happened, we reopened the popup.

I believe this is now fixed as a side-effect of some CSS/design considerations in bug 1637652 - the sidebar/toolbar now has pointer-events: none when there are open popups (to ensure no hover effects appear when a dropdown is open, because they conflict with each other), which means that no click event fires on the button, as it doesn't receive the mousedown event.

Comment 4

[Mathew Hodson]

Verified that the menus now close on click with Nightly build 20200523092124.