Closed Bug 1669112 Opened 4 years ago Closed 4 years ago

Clicking on reader mode buttons closes and immediately reopens the menus

Categories

(Toolkit :: Reader Mode, defect)

Firefox 81
Desktop
All
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- fixed

People

(Reporter: mathew.hodson, Assigned: jaws)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce:

  1. Go to https://getpocket.com/explore/item/why-detroit-residents-pushed-back-against-tree-planting
  2. Press F9 to toggle reader view
  3. Click the text or voice control button in the reader mode toolbar
  4. Click the same button again

Actual results:

The menu flashes as it closes and reopens instantly.

Expected results:

The menu should close. The buttons in reader mode should behave the same as the Pocket button, hamburger menu, and other buttons in the main toolbar.

Regressed by: 1655402
See Also: → 1638223, 1642510
Has Regression Range: --- → yes
Summary: Clicking on reader mode closes and immediately reopens the menus → Clicking on reader mode buttons closes and immediately reopens the menus

Jared, can you take a look as you wrote the patch in bug 1655402?

Flags: needinfo?(jaws)

Set release status flags based on info from the regressing bug 1655402

Assignee: nobody → jaws
Version: Firefox 82 → Firefox 81
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4db17720994
Don't close the menu in mousedown if it will get reopened by the click event handler. r=Gijs
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: