1638420 - about:debugging tab list no longer shows tab titles for Firefox Preview

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[David Walsh :davidwalsh]

Attachment: AboutDebuggingTabs.png

In the tab listing of about:debugging, we should show tab titles instead of displaying the URL twice.

Comment 1

[Julian Descottes [:jdescottes]]

We normally show the title. Were you connected to a remote device via USB? Can you share which browser it was (FF preview release or nightly?)

Comment 2

[Julian Descottes [:jdescottes]]

This might have regressed with Bug 1628117.

Agi: In about:debugging we fetch the title of a tab from the parent process, based on the corresponding <browser> element via

function getTabTitle(browser) {
  const tabBrowser = browser.getTabBrowser();
  const tab = tabBrowser.getTabForBrowser(browser);
  return tab.label;
}

(this is a shortened version of https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/devtools/server/actors/descriptors/tab.js#201 without the irrelevant devtools bits and indirections)

It seems this doesn't work on GeckoView, since getTabBrowser() doesn't return anything.
I'm not 100% sure it's a regression from Bug 1628117 since before FF77, we used to fetch the information from the content process.
Is there any way we can fetch the title of the tab from a GeckoView <browser> instance?

Edit: I see a "_contentTitle" property on the GeckoView browser instance? Is this something we could rely on?

Comment 3

[Julian Descottes [:jdescottes]]

(clearing the ni? for David, I could check that this occurred on Firefox Preview Nightly)

Comment 4

[Julian Descottes [:jdescottes]]

Seems like we could use the contentTitle property for regular Firefox Desktop as well.
I suppose the .getTabBrowser() -> .getTabForBrowser() indirection was really only useful for zombie tab?
We should check if this can be helpful for sessionrestore tabs on Firefox Desktop, but we should fallback to browser.contentTitle instead of null at https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/devtools/server/actors/descriptors/tab.js#212

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Julian Descottes [:jdescottes] from comment #2)

This might have regressed with Bug 1628117.

Agi: In about:debugging we fetch the title of a tab from the parent process, based on the corresponding <browser> element via

function getTabTitle(browser) {
  const tabBrowser = browser.getTabBrowser();
  const tab = tabBrowser.getTabForBrowser(browser);
  return tab.label;
}

yeah tab is a bare bone object for us, that code is unlikely to work (and hasn't worked in years)

Edit: I see a "_contentTitle" property on the GeckoView browser instance? Is this something we could rely on?

I think you should be able to use browser.contentTitle on all platforms? https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/toolkit/content/widgets/browser-custom-element.js#731-735

Comment 6

[Julian Descottes [:jdescottes]]

Hi David,

I was hoping to get this in the current release, are you actively working on this?

Comment 7

[David Walsh :davidwalsh]

I won't have time to work on this, unfortunately, as I'm full-time Fenix for the next few weeks.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1638420 - Read tab descriptor title from browser.contentTitle

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b9f1712970
Read tab descriptor title from browser.contentTitle r=daisuke

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d5b9f1712970