1638519 - DE glossary.xhtml: Wrong hyperlink syntax '<a href="world_wide_web">'

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce with installation of unofficial (by wg9s) De SeaMonkey 2.53.3beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20200510220906 (Default Classic Theme, newly created User Profile) on German WIN7 64bit

1. Launch Browser
2. Click
3. ˋ<f1> for Help → Search Help for "Suchmaschine" → Click the hitˊ
4. Click link behind "World Wide Web"
   » Expected: Web Page or new Help or new heading in help opens
   Actual: Warning Message 😥

a) Reason is wrong hyperlink syntax "<a href="world_wide_web">World Wide Web</a> "
Should be <a href="#world_wide_web">World Wide Web (WWW)</a>
b) Works fine in English Language

Comment 1

[Nuno Silva [:njsg]]

Attachment: de glossary.xhtml patch v1

Patch to add the #.
(Should I wrap these two long lines?)

Comment 2

[Ian Neal]

(In reply to Nuno Silva from comment #1)

Created attachment 9149611 [details] [diff] [review]
de glossary.xhtml patch v1

Patch to add the #.
(Should I wrap these two long lines?)

Yes, wherever possible try to keep to the 80 character limit.

Comment 3

[Ian Neal]

Comment on attachment 9149611 [details] [diff] [review]
de glossary.xhtml patch v1

frg is a better person to provide feedback on this.

Comment 4

[Nuno Silva [:njsg]]

Attachment: de help patch v2

A new patch that also addresses bug 1638525 as well as certs_help.xhtml.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9149653 [details] [diff] [review]
de help patch v2

Looks good to me. There is another broken link in the de help: suite/chrome/common/help/welcome_help.xhtml.
chrome://help/locale/help_help.xhtml is not valid.

> -<p>F&#252;r mehr Informationen zur Benutzung der &brandShortName;-Hilfe, siehe <a href="chrome://help/locale/help_help.xhtml">Benutzung des Hilfe-Fensters</a>.</p>

> +<p>F&#252;r mehr Informationen zur Benutzung der &brandShortName;-Hilfe, siehe <a href="help_help.xhtml">Benutzung des Hilfe-Fensters</a>.</p>

Could you probably include this one too and upload a new patch. f+ because of this but the patch itself is fine.

Comment 6

[Nuno Silva [:njsg]]

Attachment: de help patch v3

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9149684 [details] [diff] [review]
de help patch v3

LGTM 
In theory this is an l10n bug. Given the fact that I more or less do the de translations can stay in this component :) I will see that it goes into 2.53 and 2.57 and is not lost for a later l10n central.

Comment 8

[Rainer Bielefeld]

@FRG:
if you find a better way how to report these bugs please tell, I will follow the advice.

Comment 9

[Ian Neal]

(In reply to Rainer Bielefeld from comment #8)

@FRG:
if you find a better way how to report these bugs please tell, I will follow the advice.

I would say for help content, best to start with it being logged against here, it can always be moved to a different product/component if required later.

Comment 10

[Frank-Rainer Grahl (:frg)]

Not really. I wish. For de or just link changes they can stay here for now for sure. We need to do something about help content in the future anyway. Not really changeable by localizers in poonton. And as IanN wrote we can always move them later.

Comment 11

[Frank-Rainer Grahl (:frg)]

Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-l10n/-/commit/0a7587de9e563c94688207809984287f229d514f
Add missing # to link targets in help. r=frg a=frg

Not in l10n-central but consider it fixed. Will be picked up from out patches queues for 2.57 and up till we move help documentation around.