1638568 - Calling gl.uniform3fv with undefined uniform location causes unexpected errors

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Sergey]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Open this page with Firefox 75.0 or 76.0:
https://sergeyext.github.io/sergeyext/firefox_gluniform3fv_test.html
Then open console (F12)

Actual results:

There are two errors in console:

1. WebGL warning: uniform setter: values length (4) must be a positive integer multiple of size of <enum 0x8b51>.

2. GL error state is set to GL_INVALID_VALUE.

Expected results:

Should be no errors.

Some renderers control their shader features with shader source modification and/or glsl preprocessor macros. Such shader design can cause some uniforms to be optimized out. In this case getUniformLocation returns null, and it should be perfectly OK to pass null or undefined to uniform setter functions. It is similar to passing -1 as uniform location in GL ES3, in which case the passed in values are silently ignored.

When passing null or undefined to glUniform3fv in FF 75 or 76, it warns that array length should be multiple of sizeof<enum 0x8b51> (i.e. sizeof vec3, 12 bytes), which is completely irrelevant, as the same call with valid uniform location object does not have such requirement.
Also, gl error state is set to GL_INVALID_VALUE, which seems to be irrelevant too, as in ES3 this error is only generated when count is less than 0.

Comment 1

[Sergey]

Tested on Windows 10 and Linux x64 with Intel 630 and Nvidia GTX950M GPUs.
Firefox 73.0 didn't have this issue.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: error.PNG

Hi,

I was able to replicate the issue on windows 10 pro, on nightly 82.0a1 (2020-08-27) (64-bit) , beta 81.0b2, and release 80.0 (64-bit)

I'll update the bug's status accordingly.
Best,
Clara

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1638568 - E.g. uniform1i(null, ...) should check avail len not total len.

Also:

• Propagate null-location UniformDatas to host
• Move transpose validation to host-side

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8beab63e553
E.g. uniform1i(null, ...) should check avail len not total len. r=lsalzman

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a8beab63e553

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial errors using old Nightly from 2020-08-28, verified that no errors are shown in console using Firefox 85.0b3 across platforms (Windows 10 64bit, macOS 11 and Ubuntu 18.04).