1638670 - Combine ScriptStencil / ScriptStencilBase / BCEScriptStencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

After Bug 1638470, we can combine ScriptStencil and ScriptStencilBase. The split was introduced to complete Bug 1618636, but with the virtual methods gone it isn't necessary.

Comment 1

[Ted Campbell [:tcampbell]]

Also remove BCEScriptStencil

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1638670 - Replace BCEScriptStencil with ScriptStencil. r?mgaudet

The BCE is no longer needed to instantiate a Stencil, so we can directly use
the ScriptStencil type. Add an intoStencil method to the BCE to do the
setup. This replaces the old BCEScriptStencil::init method.

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1638670 - Combine ScriptStencil with ScriptStencilBase. r?mgaudet

These were originally split due to ScriptStencil using virtual methods. Those
methods no longer exist so we can simplify this.

Depends on D76023

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1638670 - Move ScriptStencil::intoScript to JSScript::fromStencil. r?mgaudet

Behaviour is the same, but we move it closer to the definition of
JSScript::fullyInitFromStencil which is still directly used by the
delazification case.

Depends on D76024

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab68e0e1e79
Replace BCEScriptStencil with ScriptStencil. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b6bd6cb99d28
Combine ScriptStencil with ScriptStencilBase. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/60c81cfd3a60
Move ScriptStencil::intoScript to JSScript::fromStencil. r=mgaudet

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1ab68e0e1e79
https://hg.mozilla.org/mozilla-central/rev/b6bd6cb99d28
https://hg.mozilla.org/mozilla-central/rev/60c81cfd3a60