1638798 - Optimize generic unary Math functions in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

MMathFunction has an enum for all Math functions it handles. It would be really nice to share this enum with CacheIR and add an enum-value => function pointer helper.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1638798 part 1 - Replace MMathFunction::Function enum with UnaryMathFunction enum class. r?evilpie!

CacheIR code will use this enum class too.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1638798 part 2 - Factor out code to convert UnaryMathFunction to function pointer or string. r?evilpie!

Already removes some duplication between GVN and CodeGenerator.

Depends on D75805

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1638798 part 3 - Optimize Math functions implemented with a C++ call in CacheIR and Warp. r?evilpie!

For now this only optimizes the Math functions where Ion always uses a C++ call.

Depends on D75806

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a1cff83052c
part 1 - Replace MMathFunction::Function enum with UnaryMathFunction enum class. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/c8893d381a57
part 2 - Factor out code to convert UnaryMathFunction to function pointer or string. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/0988119e8cf6
part 3 - Optimize Math functions implemented with a C++ call in CacheIR and Warp. r=evilpie

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9a1cff83052c
https://hg.mozilla.org/mozilla-central/rev/c8893d381a57
https://hg.mozilla.org/mozilla-central/rev/0988119e8cf6