1639113 - Optimize Math.round in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

Based on the uses in Kraken, it seems we need to support:

• number => int32
• number => double (easy after bug 1638798)

Ion has optimized codegen for the first one, it would be nice to move that to the MacroAssembler and reuse it.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1639113 part 1 - Add truncateDoubleToInt32/truncateFloat32ToInt32 to the MacroAssembler. r?evilpie!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1639113 part 2 - Move LRound/LRoundF code to the MacroAssembler. r?evilpie!

Depends on D75955

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1639113 part 3 - Add AutoAvailableFloatRegister class to assert correct FloatRegister use. r?anba!

The reason for doing this is to ensure these float registers are available for the
Math instructions (Ion doesn't have a Call IC yet but that might change).

This found an actual bug with StoreTypedObjectScalarProperty, fixed by adding
FloatReg0 also as temp register for SetProp ICs (in addition to SetElem ICs).

Depends on D75957

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1639113 part 4 - Optimize Math.round in CacheIR. r?evilpie!

Depends on D75958

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1639113 part 5 - Transpile Math.round in Warp. r?evilpie!

Depends on D75959

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180e48bc3c41
part 1 - Add truncateDoubleToInt32/truncateFloat32ToInt32 to the MacroAssembler. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/bc823c0fd292
part 2 - Move LRound/LRoundF code to the MacroAssembler. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/c8cc2b355422
part 3 - Add AutoAvailableFloatRegister class to assert correct FloatRegister use. r=anba
https://hg.mozilla.org/integration/autoland/rev/5aff4aae9701
part 4 - Optimize Math.round in CacheIR. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/b939cecf3fca
part 5 - Transpile Math.round in Warp. r=evilpie

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/180e48bc3c41
https://hg.mozilla.org/mozilla-central/rev/bc823c0fd292
https://hg.mozilla.org/mozilla-central/rev/c8cc2b355422
https://hg.mozilla.org/mozilla-central/rev/5aff4aae9701
https://hg.mozilla.org/mozilla-central/rev/b939cecf3fca