Closed
Bug 1639035
Opened 4 years ago
Closed 4 years ago
Replace openContextMenuInFrame("#frame") with openContextMenuInFrame() in tests
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox-esr68 unaffected, firefox76 wontfix, firefox77 wontfix, firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | wontfix |
| firefox77 | --- | wontfix |
| firefox78 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1573839 changed the signature of the openContextMenuInFrame test helper.
It used to take the selector of the frame, but now it is the selector of the page content.
When I ran some menu-related extensions tests, some frame-related tests failed consistently. This is because the openContextMenuInFrame will still open a menu, but at the upper-left corner instead of the center of the frame. The menu ends up being anchored outside the frame (I guess due to rounding issues) and the tests that expect the menu inside the frame fail.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Type: task → defect
|
|
||
Updated•4 years ago
|
Keywords: regression
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/9873bb36ca3b Fix callers of openContextMenuInFrame in tests r=rpl
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•4 years ago
|
status-firefox76:
--- → wontfix
status-firefox77:
--- → wontfix
status-firefox-esr68:
--- → unaffected
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•