1573839 - Change BrowserTestUtils synthesizeMouse/etc to handle out of process frames

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Neil Deakin]

This involves waiting for child iframes to load as well as being able to synthesize mouse/key events in child iframes.

Comment 1

[Kris Maglione [:kmag]]

Note that Kashav is currently working on some of these helper methods

Comment 2

[Neil Deakin]

Attachment: Bug 1573839, modify BrowserTestUtils.synthesizeMouse/Key/etc to handle fission. Remove support for passing arrays of selectors and instead modify the last argument to be a browsing context, or browser. Fix up tests that use this obsolete form, r=kmag

Comment 3

[Neil Deakin]

Note that bug 1559841 is needed to run some of the tests that use this.

Comment 4

[Neil Deakin]

Attachment: Bug 1573839, change browser_context_menu_iframe.js to pass a browsing context for synthesizeMouse calls, also fixes test_context_menu_iframe_sandbox_same_origin test that was incorrectly using the wrong frame, r=MattN

Comment 5

[Neil Deakin]

I had this extra test_context_menu_iframe.js change in my password manager set of patches but it actually belongs here as it would otherwise fail.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4202682c55
modify BrowserTestUtils.synthesizeMouse/Key/etc to handle fission. Remove support for passing arrays of selectors and instead modify the last argument to be a browsing context, or browser. Fix up tests that use this obsolete form, r=kmag
https://hg.mozilla.org/integration/autoland/rev/d79153e62c0c
change browser_context_menu_iframe.js to pass a browsing context for synthesizeMouse calls, also fixes test_context_menu_iframe_sandbox_same_origin test that was incorrectly using the wrong frame, r=MattN

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Based on the following link, i think these changes have increased bug 1430977 frequency:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s&fromchange=05273fba6dadc286c4b61baa77cce7bf599e41c0&tochange=f7d1df2061e77d556eb36fac6b87c629d12f4038&selectedJob=270044113

Neil, could you, please, take a look?

Comment 8

[Neil Deakin]

The browser_625016.js test fails for me locally every single time whether I have the changes in this bug applied or not. As my changes here are test-only changes unrelated to this failing test, I would instead suggest that that browser_625016.js is just broken entirely.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4b4202682c55
https://hg.mozilla.org/mozilla-central/rev/d79153e62c0c